[drupal-devel] [bug] Don't hard code forms into comment.module
Issue status update for http://drupal.org/node/23620 Project: Drupal Version: cvs Component: comment.module Category: bug reports Priority: normal Assigned to: Robin Monks Reported by: Robin Monks Updated by: Robin Monks Status: patch Attachment: http://drupal.org/files/issues/Comment.Control.hardcode.patch (4.02 KB) This patch removes all those nasty hard coded forms from comment.module's user Comment Control. Robin Robin Monks
Issue status update for http://drupal.org/node/23620 Project: Drupal Version: cvs Component: comment.module Category: bug reports Priority: normal Assigned to: Robin Monks Reported by: Robin Monks Updated by: Robin Monks Status: patch Oh, and I've test this, and it works. Robin Robin Monks Previous comments: ------------------------------------------------------------------------ May 25, 2005 - 22:09 : Robin Monks Attachment: http://drupal.org/files/issues/Comment.Control.hardcode.patch (4.02 KB) This patch removes all those nasty hard coded forms from comment.module's user Comment Control. Robin
Issue status update for http://drupal.org/node/23620 Project: Drupal Version: cvs Component: comment.module Category: bug reports Priority: normal Assigned to: Robin Monks Reported by: Robin Monks Updated by: Robin Monks Status: patch Attachment: http://drupal.org/files/issues/Comment.Control.hardcode_0.patch (3.96 KB) A bug I missed (thanks UnConeD!). Robin Robin Monks Previous comments: ------------------------------------------------------------------------ May 25, 2005 - 22:09 : Robin Monks Attachment: http://drupal.org/files/issues/Comment.Control.hardcode.patch (4.02 KB) This patch removes all those nasty hard coded forms from comment.module's user Comment Control. Robin ------------------------------------------------------------------------ May 25, 2005 - 22:16 : Robin Monks Oh, and I've test this, and it works. Robin
Issue status update for http://drupal.org/node/23620 Project: Drupal Version: cvs Component: comment.module Category: bug reports Priority: normal Assigned to: Robin Monks Reported by: Robin Monks Updated by: drumm Status: patch I read over the code quickly and this caught my eye: + $filter = db_fetch_object($result); + $filter[0] = t('-- threshold --'); Even though PHP might not complain we should prolly decide on array or object. drumm Previous comments: ------------------------------------------------------------------------ May 25, 2005 - 16:09 : Robin Monks Attachment: http://drupal.org/files/issues/Comment.Control.hardcode.patch (4.02 KB) This patch removes all those nasty hard coded forms from comment.module's user Comment Control. Robin ------------------------------------------------------------------------ May 25, 2005 - 16:16 : Robin Monks Oh, and I've test this, and it works. Robin ------------------------------------------------------------------------ May 25, 2005 - 16:26 : Robin Monks Attachment: http://drupal.org/files/issues/Comment.Control.hardcode_0.patch (3.96 KB) A bug I missed (thanks UnConeD!). Robin
Issue status update for http://drupal.org/node/23620 Project: Drupal Version: cvs Component: comment.module Category: bug reports Priority: normal Assigned to: Robin Monks Reported by: Robin Monks Updated by: Robin Monks Status: patch Attachment: http://drupal.org/files/issues/Comment.Control.hardcode_1.patch (3.96 KB) Good point, I missed that. Robin Robin Monks Previous comments: ------------------------------------------------------------------------ May 25, 2005 - 22:09 : Robin Monks Attachment: http://drupal.org/files/issues/Comment.Control.hardcode.patch (4.02 KB) This patch removes all those nasty hard coded forms from comment.module's user Comment Control. Robin ------------------------------------------------------------------------ May 25, 2005 - 22:16 : Robin Monks Oh, and I've test this, and it works. Robin ------------------------------------------------------------------------ May 25, 2005 - 22:26 : Robin Monks Attachment: http://drupal.org/files/issues/Comment.Control.hardcode_0.patch (3.96 KB) A bug I missed (thanks UnConeD!). Robin ------------------------------------------------------------------------ May 25, 2005 - 23:44 : drumm I read over the code quickly and this caught my eye: + $filter = db_fetch_object($result); + $filter[0] = t('-- threshold --'); Even though PHP might not complain we should prolly decide on array or object.
Issue status update for http://drupal.org/node/23620 Project: Drupal Version: cvs Component: comment.module Category: bug reports Priority: normal Assigned to: Robin Monks Reported by: Robin Monks Updated by: Robin Monks Status: patch Attachment: http://drupal.org/files/issues/Comment.Control.hardcode..patch (3.96 KB) Drumm hath found another bug... Robin Robin Monks Previous comments: ------------------------------------------------------------------------ May 25, 2005 - 22:09 : Robin Monks Attachment: http://drupal.org/files/issues/Comment.Control.hardcode.patch (4.02 KB) This patch removes all those nasty hard coded forms from comment.module's user Comment Control. Robin ------------------------------------------------------------------------ May 25, 2005 - 22:16 : Robin Monks Oh, and I've test this, and it works. Robin ------------------------------------------------------------------------ May 25, 2005 - 22:26 : Robin Monks Attachment: http://drupal.org/files/issues/Comment.Control.hardcode_0.patch (3.96 KB) A bug I missed (thanks UnConeD!). Robin ------------------------------------------------------------------------ May 25, 2005 - 23:44 : drumm I read over the code quickly and this caught my eye: + $filter = db_fetch_object($result); + $filter[0] = t('-- threshold --'); Even though PHP might not complain we should prolly decide on array or object. ------------------------------------------------------------------------ May 26, 2005 - 11:16 : Robin Monks Attachment: http://drupal.org/files/issues/Comment.Control.hardcode_1.patch (3.96 KB) Good point, I missed that. Robin
Issue status update for http://drupal.org/node/23620 Project: Drupal Version: cvs Component: comment.module Category: bug reports Priority: normal Assigned to: Robin Monks Reported by: Robin Monks Updated by: Robin Monks Status: patch Attachment: http://drupal.org/files/issues/commentforms.patch (4.08 KB) Updated version with killes' comments added in the code (whitespacing) and with a lot less bulky code and theme recalls Robin Robin Monks Previous comments: ------------------------------------------------------------------------ May 25, 2005 - 22:09 : Robin Monks Attachment: http://drupal.org/files/issues/Comment.Control.hardcode.patch (4.02 KB) This patch removes all those nasty hard coded forms from comment.module's user Comment Control. Robin ------------------------------------------------------------------------ May 25, 2005 - 22:16 : Robin Monks Oh, and I've test this, and it works. Robin ------------------------------------------------------------------------ May 25, 2005 - 22:26 : Robin Monks Attachment: http://drupal.org/files/issues/Comment.Control.hardcode_0.patch (3.96 KB) A bug I missed (thanks UnConeD!). Robin ------------------------------------------------------------------------ May 25, 2005 - 23:44 : drumm I read over the code quickly and this caught my eye: + $filter = db_fetch_object($result); + $filter[0] = t('-- threshold --'); Even though PHP might not complain we should prolly decide on array or object. ------------------------------------------------------------------------ May 26, 2005 - 11:16 : Robin Monks Attachment: http://drupal.org/files/issues/Comment.Control.hardcode_1.patch (3.96 KB) Good point, I missed that. Robin ------------------------------------------------------------------------ May 26, 2005 - 16:39 : Robin Monks Attachment: http://drupal.org/files/issues/Comment.Control.hardcode..patch (3.96 KB) Drumm hath found another bug... Robin
Issue status update for http://drupal.org/node/23620 Project: Drupal Version: cvs Component: comment.module Category: bug reports Priority: normal Assigned to: Robin Monks Reported by: Robin Monks Updated by: Robin Monks Status: patch Attachment: http://drupal.org/files/issues/commentforms_0.patch (4.08 KB) Final Version, removes 4 unneeded functions. Tested to work. Please comment. Robin Robin Monks Previous comments: ------------------------------------------------------------------------ May 25, 2005 - 22:09 : Robin Monks Attachment: http://drupal.org/files/issues/Comment.Control.hardcode.patch (4.02 KB) This patch removes all those nasty hard coded forms from comment.module's user Comment Control. Robin ------------------------------------------------------------------------ May 25, 2005 - 22:16 : Robin Monks Oh, and I've test this, and it works. Robin ------------------------------------------------------------------------ May 25, 2005 - 22:26 : Robin Monks Attachment: http://drupal.org/files/issues/Comment.Control.hardcode_0.patch (3.96 KB) A bug I missed (thanks UnConeD!). Robin ------------------------------------------------------------------------ May 25, 2005 - 23:44 : drumm I read over the code quickly and this caught my eye: + $filter = db_fetch_object($result); + $filter[0] = t('-- threshold --'); Even though PHP might not complain we should prolly decide on array or object. ------------------------------------------------------------------------ May 26, 2005 - 11:16 : Robin Monks Attachment: http://drupal.org/files/issues/Comment.Control.hardcode_1.patch (3.96 KB) Good point, I missed that. Robin ------------------------------------------------------------------------ May 26, 2005 - 16:39 : Robin Monks Attachment: http://drupal.org/files/issues/Comment.Control.hardcode..patch (3.96 KB) Drumm hath found another bug... Robin ------------------------------------------------------------------------ June 9, 2005 - 00:12 : Robin Monks Attachment: http://drupal.org/files/issues/commentforms.patch (4.08 KB) Updated version with killes' comments added in the code (whitespacing) and with a lot less bulky code and theme recalls Robin
Issue status update for http://drupal.org/node/23620 Project: Drupal Version: cvs Component: comment.module Category: bug reports Priority: normal Assigned to: Robin Monks Reported by: Robin Monks Updated by: Robin Monks Status: patch Attachment: http://drupal.org/files/issues/commentform.patch (4.04 KB) Yelp, wrong patch.... Robin Monks Previous comments: ------------------------------------------------------------------------ May 25, 2005 - 22:09 : Robin Monks Attachment: http://drupal.org/files/issues/Comment.Control.hardcode.patch (4.02 KB) This patch removes all those nasty hard coded forms from comment.module's user Comment Control. Robin ------------------------------------------------------------------------ May 25, 2005 - 22:16 : Robin Monks Oh, and I've test this, and it works. Robin ------------------------------------------------------------------------ May 25, 2005 - 22:26 : Robin Monks Attachment: http://drupal.org/files/issues/Comment.Control.hardcode_0.patch (3.96 KB) A bug I missed (thanks UnConeD!). Robin ------------------------------------------------------------------------ May 25, 2005 - 23:44 : drumm I read over the code quickly and this caught my eye: + $filter = db_fetch_object($result); + $filter[0] = t('-- threshold --'); Even though PHP might not complain we should prolly decide on array or object. ------------------------------------------------------------------------ May 26, 2005 - 11:16 : Robin Monks Attachment: http://drupal.org/files/issues/Comment.Control.hardcode_1.patch (3.96 KB) Good point, I missed that. Robin ------------------------------------------------------------------------ May 26, 2005 - 16:39 : Robin Monks Attachment: http://drupal.org/files/issues/Comment.Control.hardcode..patch (3.96 KB) Drumm hath found another bug... Robin ------------------------------------------------------------------------ June 9, 2005 - 00:12 : Robin Monks Attachment: http://drupal.org/files/issues/commentforms.patch (4.08 KB) Updated version with killes' comments added in the code (whitespacing) and with a lot less bulky code and theme recalls Robin ------------------------------------------------------------------------ June 9, 2005 - 11:16 : Robin Monks Attachment: http://drupal.org/files/issues/commentforms_0.patch (4.08 KB) Final Version, removes 4 unneeded functions. Tested to work. Please comment. Robin
Issue status update for http://drupal.org/node/23620 Project: Drupal Version: cvs Component: comment.module Category: bug reports Priority: normal Assigned to: Robin Monks Reported by: Robin Monks Updated by: Jose A Reyero Status: patch After applying this patch, the "threshold" drop-down is gone. Jose A Reyero Previous comments: ------------------------------------------------------------------------ May 25, 2005 - 23:09 : Robin Monks Attachment: http://drupal.org/files/issues/Comment.Control.hardcode.patch (4.02 KB) This patch removes all those nasty hard coded forms from comment.module's user Comment Control. Robin ------------------------------------------------------------------------ May 25, 2005 - 23:16 : Robin Monks Oh, and I've test this, and it works. Robin ------------------------------------------------------------------------ May 25, 2005 - 23:26 : Robin Monks Attachment: http://drupal.org/files/issues/Comment.Control.hardcode_0.patch (3.96 KB) A bug I missed (thanks UnConeD!). Robin ------------------------------------------------------------------------ May 26, 2005 - 00:44 : drumm I read over the code quickly and this caught my eye: + $filter = db_fetch_object($result); + $filter[0] = t('-- threshold --'); Even though PHP might not complain we should prolly decide on array or object. ------------------------------------------------------------------------ May 26, 2005 - 12:16 : Robin Monks Attachment: http://drupal.org/files/issues/Comment.Control.hardcode_1.patch (3.96 KB) Good point, I missed that. Robin ------------------------------------------------------------------------ May 26, 2005 - 17:39 : Robin Monks Attachment: http://drupal.org/files/issues/Comment.Control.hardcode..patch (3.96 KB) Drumm hath found another bug... Robin ------------------------------------------------------------------------ June 9, 2005 - 01:12 : Robin Monks Attachment: http://drupal.org/files/issues/commentforms.patch (4.08 KB) Updated version with killes' comments added in the code (whitespacing) and with a lot less bulky code and theme recalls Robin ------------------------------------------------------------------------ June 9, 2005 - 12:16 : Robin Monks Attachment: http://drupal.org/files/issues/commentforms_0.patch (4.08 KB) Final Version, removes 4 unneeded functions. Tested to work. Please comment. Robin ------------------------------------------------------------------------ June 9, 2005 - 12:24 : Robin Monks Attachment: http://drupal.org/files/issues/commentform.patch (4.04 KB) Yelp, wrong patch....
Issue status update for http://drupal.org/node/23620 Post a follow up: http://drupal.org/project/comments/add/23620 Project: Drupal Version: cvs Component: comment.module Category: bug reports Priority: normal Assigned to: Robin Monks Reported by: Robin Monks Updated by: Robin Monks Status: patch (code needs review) Attachment: http://drupal.org/files/issues/moderation_forms.patch (4.48 KB) There was a glitch in the patch that caused the threshhold dropdown never to display. This version fixes that, although moderation may be broken already by Moshe's patch (as it won't work with, or without, this patch). Robin Robin Monks Previous comments: ------------------------------------------------------------------------ Wed, 25 May 2005 22:09:12 +0000 : Robin Monks Attachment: http://drupal.org/files/issues/Comment.Control.hardcode.patch (4.02 KB) This patch removes all those nasty hard coded forms from comment.module's user Comment Control. Robin ------------------------------------------------------------------------ Wed, 25 May 2005 22:16:52 +0000 : Robin Monks Oh, and I've test this, and it works. Robin ------------------------------------------------------------------------ Wed, 25 May 2005 22:26:37 +0000 : Robin Monks Attachment: http://drupal.org/files/issues/Comment.Control.hardcode_0.patch (3.96 KB) A bug I missed (thanks UnConeD!). Robin ------------------------------------------------------------------------ Wed, 25 May 2005 23:44:45 +0000 : drumm I read over the code quickly and this caught my eye: + $filter = db_fetch_object($result); + $filter[0] = t('-- threshold --'); Even though PHP might not complain we should prolly decide on array or object. ------------------------------------------------------------------------ Thu, 26 May 2005 11:16:44 +0000 : Robin Monks Attachment: http://drupal.org/files/issues/Comment.Control.hardcode_1.patch (3.96 KB) Good point, I missed that. Robin ------------------------------------------------------------------------ Thu, 26 May 2005 16:39:19 +0000 : Robin Monks Attachment: http://drupal.org/files/issues/Comment.Control.hardcode..patch (3.96 KB) Drumm hath found another bug... Robin ------------------------------------------------------------------------ Thu, 09 Jun 2005 00:12:42 +0000 : Robin Monks Attachment: http://drupal.org/files/issues/commentforms.patch (4.08 KB) Updated version with killes' comments added in the code (whitespacing) and with a lot less bulky code and theme recalls Robin ------------------------------------------------------------------------ Thu, 09 Jun 2005 11:16:00 +0000 : Robin Monks Attachment: http://drupal.org/files/issues/commentforms_0.patch (4.08 KB) Final Version, removes 4 unneeded functions. Tested to work. Please comment. Robin ------------------------------------------------------------------------ Thu, 09 Jun 2005 11:24:16 +0000 : Robin Monks Attachment: http://drupal.org/files/issues/commentform.patch (4.04 KB) Yelp, wrong patch.... ------------------------------------------------------------------------ Fri, 01 Jul 2005 15:22:35 +0000 : Jose A Reyero After applying this patch, the "threshold" drop-down is gone.
Issue status update for http://drupal.org/node/23620 Post a follow up: http://drupal.org/project/comments/add/23620 Project: Drupal Version: cvs Component: comment.module Category: bug reports Priority: normal Assigned to: Robin Monks Reported by: Robin Monks Updated by: killes@www.drop.org Status: patch (code needs review) The patch looks very nice becasue it removes a lot of crufty code. I've no time to test it, though. killes@www.drop.org Previous comments: ------------------------------------------------------------------------ Wed, 25 May 2005 22:09:12 +0000 : Robin Monks Attachment: http://drupal.org/files/issues/Comment.Control.hardcode.patch (4.02 KB) This patch removes all those nasty hard coded forms from comment.module's user Comment Control. Robin ------------------------------------------------------------------------ Wed, 25 May 2005 22:16:52 +0000 : Robin Monks Oh, and I've test this, and it works. Robin ------------------------------------------------------------------------ Wed, 25 May 2005 22:26:37 +0000 : Robin Monks Attachment: http://drupal.org/files/issues/Comment.Control.hardcode_0.patch (3.96 KB) A bug I missed (thanks UnConeD!). Robin ------------------------------------------------------------------------ Wed, 25 May 2005 23:44:45 +0000 : drumm I read over the code quickly and this caught my eye: + $filter = db_fetch_object($result); + $filter[0] = t('-- threshold --'); Even though PHP might not complain we should prolly decide on array or object. ------------------------------------------------------------------------ Thu, 26 May 2005 11:16:44 +0000 : Robin Monks Attachment: http://drupal.org/files/issues/Comment.Control.hardcode_1.patch (3.96 KB) Good point, I missed that. Robin ------------------------------------------------------------------------ Thu, 26 May 2005 16:39:19 +0000 : Robin Monks Attachment: http://drupal.org/files/issues/Comment.Control.hardcode..patch (3.96 KB) Drumm hath found another bug... Robin ------------------------------------------------------------------------ Thu, 09 Jun 2005 00:12:42 +0000 : Robin Monks Attachment: http://drupal.org/files/issues/commentforms.patch (4.08 KB) Updated version with killes' comments added in the code (whitespacing) and with a lot less bulky code and theme recalls Robin ------------------------------------------------------------------------ Thu, 09 Jun 2005 11:16:00 +0000 : Robin Monks Attachment: http://drupal.org/files/issues/commentforms_0.patch (4.08 KB) Final Version, removes 4 unneeded functions. Tested to work. Please comment. Robin ------------------------------------------------------------------------ Thu, 09 Jun 2005 11:24:16 +0000 : Robin Monks Attachment: http://drupal.org/files/issues/commentform.patch (4.04 KB) Yelp, wrong patch.... ------------------------------------------------------------------------ Fri, 01 Jul 2005 15:22:35 +0000 : Jose A Reyero After applying this patch, the "threshold" drop-down is gone. ------------------------------------------------------------------------ Wed, 10 Aug 2005 13:48:54 +0000 : Robin Monks Attachment: http://drupal.org/files/issues/moderation_forms.patch (4.48 KB) There was a glitch in the patch that caused the threshhold dropdown never to display. This version fixes that, although moderation may be broken already by Moshe's patch (as it won't work with, or without, this patch). Robin
Issue status update for http://drupal.org/node/23620 Post a follow up: http://drupal.org/project/comments/add/23620 Project: Drupal Version: cvs Component: comment.module Category: bug reports Priority: normal Assigned to: Robin Monks Reported by: Robin Monks Updated by: Dries Status: patch (code needs review) This patch is likely to be deprecated when the new form API is ready. I'm OK with it but haven't tested it yet. Dries Previous comments: ------------------------------------------------------------------------ Wed, 25 May 2005 22:09:12 +0000 : Robin Monks Attachment: http://drupal.org/files/issues/Comment.Control.hardcode.patch (4.02 KB) This patch removes all those nasty hard coded forms from comment.module's user Comment Control. Robin ------------------------------------------------------------------------ Wed, 25 May 2005 22:16:52 +0000 : Robin Monks Oh, and I've test this, and it works. Robin ------------------------------------------------------------------------ Wed, 25 May 2005 22:26:37 +0000 : Robin Monks Attachment: http://drupal.org/files/issues/Comment.Control.hardcode_0.patch (3.96 KB) A bug I missed (thanks UnConeD!). Robin ------------------------------------------------------------------------ Wed, 25 May 2005 23:44:45 +0000 : drumm I read over the code quickly and this caught my eye: + $filter = db_fetch_object($result); + $filter[0] = t('-- threshold --'); Even though PHP might not complain we should prolly decide on array or object. ------------------------------------------------------------------------ Thu, 26 May 2005 11:16:44 +0000 : Robin Monks Attachment: http://drupal.org/files/issues/Comment.Control.hardcode_1.patch (3.96 KB) Good point, I missed that. Robin ------------------------------------------------------------------------ Thu, 26 May 2005 16:39:19 +0000 : Robin Monks Attachment: http://drupal.org/files/issues/Comment.Control.hardcode..patch (3.96 KB) Drumm hath found another bug... Robin ------------------------------------------------------------------------ Thu, 09 Jun 2005 00:12:42 +0000 : Robin Monks Attachment: http://drupal.org/files/issues/commentforms.patch (4.08 KB) Updated version with killes' comments added in the code (whitespacing) and with a lot less bulky code and theme recalls Robin ------------------------------------------------------------------------ Thu, 09 Jun 2005 11:16:00 +0000 : Robin Monks Attachment: http://drupal.org/files/issues/commentforms_0.patch (4.08 KB) Final Version, removes 4 unneeded functions. Tested to work. Please comment. Robin ------------------------------------------------------------------------ Thu, 09 Jun 2005 11:24:16 +0000 : Robin Monks Attachment: http://drupal.org/files/issues/commentform.patch (4.04 KB) Yelp, wrong patch.... ------------------------------------------------------------------------ Fri, 01 Jul 2005 15:22:35 +0000 : Jose A Reyero After applying this patch, the "threshold" drop-down is gone. ------------------------------------------------------------------------ Wed, 10 Aug 2005 13:48:54 +0000 : Robin Monks Attachment: http://drupal.org/files/issues/moderation_forms.patch (4.48 KB) There was a glitch in the patch that caused the threshhold dropdown never to display. This version fixes that, although moderation may be broken already by Moshe's patch (as it won't work with, or without, this patch). Robin ------------------------------------------------------------------------ Wed, 10 Aug 2005 21:11:41 +0000 : killes@www.drop.org The patch looks very nice becasue it removes a lot of crufty code. I've no time to test it, though.
Issue status update for http://drupal.org/node/23620 Post a follow up: http://drupal.org/project/comments/add/23620 Project: Drupal Version: cvs Component: comment.module Category: bug reports Priority: normal Assigned to: Robin Monks Reported by: Robin Monks Updated by: drumm Status: patch (code needs review) I think this can only make the form converting job easier. Lets go ahead and put this patch in once reviewed unless anyone working directly on the new form api objects. drumm Previous comments: ------------------------------------------------------------------------ Wed, 25 May 2005 22:09:12 +0000 : Robin Monks Attachment: http://drupal.org/files/issues/Comment.Control.hardcode.patch (4.02 KB) This patch removes all those nasty hard coded forms from comment.module's user Comment Control. Robin ------------------------------------------------------------------------ Wed, 25 May 2005 22:16:52 +0000 : Robin Monks Oh, and I've test this, and it works. Robin ------------------------------------------------------------------------ Wed, 25 May 2005 22:26:37 +0000 : Robin Monks Attachment: http://drupal.org/files/issues/Comment.Control.hardcode_0.patch (3.96 KB) A bug I missed (thanks UnConeD!). Robin ------------------------------------------------------------------------ Wed, 25 May 2005 23:44:45 +0000 : drumm I read over the code quickly and this caught my eye: + $filter = db_fetch_object($result); + $filter[0] = t('-- threshold --'); Even though PHP might not complain we should prolly decide on array or object. ------------------------------------------------------------------------ Thu, 26 May 2005 11:16:44 +0000 : Robin Monks Attachment: http://drupal.org/files/issues/Comment.Control.hardcode_1.patch (3.96 KB) Good point, I missed that. Robin ------------------------------------------------------------------------ Thu, 26 May 2005 16:39:19 +0000 : Robin Monks Attachment: http://drupal.org/files/issues/Comment.Control.hardcode..patch (3.96 KB) Drumm hath found another bug... Robin ------------------------------------------------------------------------ Thu, 09 Jun 2005 00:12:42 +0000 : Robin Monks Attachment: http://drupal.org/files/issues/commentforms.patch (4.08 KB) Updated version with killes' comments added in the code (whitespacing) and with a lot less bulky code and theme recalls Robin ------------------------------------------------------------------------ Thu, 09 Jun 2005 11:16:00 +0000 : Robin Monks Attachment: http://drupal.org/files/issues/commentforms_0.patch (4.08 KB) Final Version, removes 4 unneeded functions. Tested to work. Please comment. Robin ------------------------------------------------------------------------ Thu, 09 Jun 2005 11:24:16 +0000 : Robin Monks Attachment: http://drupal.org/files/issues/commentform.patch (4.04 KB) Yelp, wrong patch.... ------------------------------------------------------------------------ Fri, 01 Jul 2005 15:22:35 +0000 : Jose A Reyero After applying this patch, the "threshold" drop-down is gone. ------------------------------------------------------------------------ Wed, 10 Aug 2005 13:48:54 +0000 : Robin Monks Attachment: http://drupal.org/files/issues/moderation_forms.patch (4.48 KB) There was a glitch in the patch that caused the threshhold dropdown never to display. This version fixes that, although moderation may be broken already by Moshe's patch (as it won't work with, or without, this patch). Robin ------------------------------------------------------------------------ Wed, 10 Aug 2005 21:11:41 +0000 : killes@www.drop.org The patch looks very nice becasue it removes a lot of crufty code. I've no time to test it, though. ------------------------------------------------------------------------ Thu, 11 Aug 2005 12:32:49 +0000 : Dries This patch is likely to be deprecated when the new form API is ready. I'm OK with it but haven't tested it yet.
Issue status update for http://drupal.org/node/23620 Post a follow up: http://drupal.org/project/comments/add/23620 Project: Drupal Version: cvs Component: comment.module Category: bug reports Priority: normal Assigned to: Robin Monks Reported by: Robin Monks Updated by: killes@www.drop.org Status: patch (code needs review) Dries, please commit I can't bear it to see that crufty code in Drupal. killes@www.drop.org Previous comments: ------------------------------------------------------------------------ Wed, 25 May 2005 22:09:12 +0000 : Robin Monks Attachment: http://drupal.org/files/issues/Comment.Control.hardcode.patch (4.02 KB) This patch removes all those nasty hard coded forms from comment.module's user Comment Control. Robin ------------------------------------------------------------------------ Wed, 25 May 2005 22:16:52 +0000 : Robin Monks Oh, and I've test this, and it works. Robin ------------------------------------------------------------------------ Wed, 25 May 2005 22:26:37 +0000 : Robin Monks Attachment: http://drupal.org/files/issues/Comment.Control.hardcode_0.patch (3.96 KB) A bug I missed (thanks UnConeD!). Robin ------------------------------------------------------------------------ Wed, 25 May 2005 23:44:45 +0000 : drumm I read over the code quickly and this caught my eye: + $filter = db_fetch_object($result); + $filter[0] = t('-- threshold --'); Even though PHP might not complain we should prolly decide on array or object. ------------------------------------------------------------------------ Thu, 26 May 2005 11:16:44 +0000 : Robin Monks Attachment: http://drupal.org/files/issues/Comment.Control.hardcode_1.patch (3.96 KB) Good point, I missed that. Robin ------------------------------------------------------------------------ Thu, 26 May 2005 16:39:19 +0000 : Robin Monks Attachment: http://drupal.org/files/issues/Comment.Control.hardcode..patch (3.96 KB) Drumm hath found another bug... Robin ------------------------------------------------------------------------ Thu, 09 Jun 2005 00:12:42 +0000 : Robin Monks Attachment: http://drupal.org/files/issues/commentforms.patch (4.08 KB) Updated version with killes' comments added in the code (whitespacing) and with a lot less bulky code and theme recalls Robin ------------------------------------------------------------------------ Thu, 09 Jun 2005 11:16:00 +0000 : Robin Monks Attachment: http://drupal.org/files/issues/commentforms_0.patch (4.08 KB) Final Version, removes 4 unneeded functions. Tested to work. Please comment. Robin ------------------------------------------------------------------------ Thu, 09 Jun 2005 11:24:16 +0000 : Robin Monks Attachment: http://drupal.org/files/issues/commentform.patch (4.04 KB) Yelp, wrong patch.... ------------------------------------------------------------------------ Fri, 01 Jul 2005 15:22:35 +0000 : Jose A Reyero After applying this patch, the "threshold" drop-down is gone. ------------------------------------------------------------------------ Wed, 10 Aug 2005 13:48:54 +0000 : Robin Monks Attachment: http://drupal.org/files/issues/moderation_forms.patch (4.48 KB) There was a glitch in the patch that caused the threshhold dropdown never to display. This version fixes that, although moderation may be broken already by Moshe's patch (as it won't work with, or without, this patch). Robin ------------------------------------------------------------------------ Wed, 10 Aug 2005 21:11:41 +0000 : killes@www.drop.org The patch looks very nice becasue it removes a lot of crufty code. I've no time to test it, though. ------------------------------------------------------------------------ Thu, 11 Aug 2005 12:32:49 +0000 : Dries This patch is likely to be deprecated when the new form API is ready. I'm OK with it but haven't tested it yet. ------------------------------------------------------------------------ Thu, 11 Aug 2005 18:54:22 +0000 : drumm I think this can only make the form converting job easier. Lets go ahead and put this patch in once reviewed unless anyone working directly on the new form api objects.
Issue status update for http://drupal.org/node/23620 Post a follow up: http://drupal.org/project/comments/add/23620 Project: Drupal Version: cvs Component: comment.module Category: bug reports Priority: normal Assigned to: Robin Monks Reported by: Robin Monks Updated by: Robin Monks -Status: patch (code needs review) +Status: patch (ready to be committed) Placing in queue per Dries. Robin Robin Monks Previous comments: ------------------------------------------------------------------------ Wed, 25 May 2005 22:09:12 +0000 : Robin Monks Attachment: http://drupal.org/files/issues/Comment.Control.hardcode.patch (4.02 KB) This patch removes all those nasty hard coded forms from comment.module's user Comment Control. Robin ------------------------------------------------------------------------ Wed, 25 May 2005 22:16:52 +0000 : Robin Monks Oh, and I've test this, and it works. Robin ------------------------------------------------------------------------ Wed, 25 May 2005 22:26:37 +0000 : Robin Monks Attachment: http://drupal.org/files/issues/Comment.Control.hardcode_0.patch (3.96 KB) A bug I missed (thanks UnConeD!). Robin ------------------------------------------------------------------------ Wed, 25 May 2005 23:44:45 +0000 : drumm I read over the code quickly and this caught my eye: + $filter = db_fetch_object($result); + $filter[0] = t('-- threshold --'); Even though PHP might not complain we should prolly decide on array or object. ------------------------------------------------------------------------ Thu, 26 May 2005 11:16:44 +0000 : Robin Monks Attachment: http://drupal.org/files/issues/Comment.Control.hardcode_1.patch (3.96 KB) Good point, I missed that. Robin ------------------------------------------------------------------------ Thu, 26 May 2005 16:39:19 +0000 : Robin Monks Attachment: http://drupal.org/files/issues/Comment.Control.hardcode..patch (3.96 KB) Drumm hath found another bug... Robin ------------------------------------------------------------------------ Thu, 09 Jun 2005 00:12:42 +0000 : Robin Monks Attachment: http://drupal.org/files/issues/commentforms.patch (4.08 KB) Updated version with killes' comments added in the code (whitespacing) and with a lot less bulky code and theme recalls Robin ------------------------------------------------------------------------ Thu, 09 Jun 2005 11:16:00 +0000 : Robin Monks Attachment: http://drupal.org/files/issues/commentforms_0.patch (4.08 KB) Final Version, removes 4 unneeded functions. Tested to work. Please comment. Robin ------------------------------------------------------------------------ Thu, 09 Jun 2005 11:24:16 +0000 : Robin Monks Attachment: http://drupal.org/files/issues/commentform.patch (4.04 KB) Yelp, wrong patch.... ------------------------------------------------------------------------ Fri, 01 Jul 2005 15:22:35 +0000 : Jose A Reyero After applying this patch, the "threshold" drop-down is gone. ------------------------------------------------------------------------ Wed, 10 Aug 2005 13:48:54 +0000 : Robin Monks Attachment: http://drupal.org/files/issues/moderation_forms.patch (4.48 KB) There was a glitch in the patch that caused the threshhold dropdown never to display. This version fixes that, although moderation may be broken already by Moshe's patch (as it won't work with, or without, this patch). Robin ------------------------------------------------------------------------ Wed, 10 Aug 2005 21:11:41 +0000 : killes@www.drop.org The patch looks very nice becasue it removes a lot of crufty code. I've no time to test it, though. ------------------------------------------------------------------------ Thu, 11 Aug 2005 12:32:49 +0000 : Dries This patch is likely to be deprecated when the new form API is ready. I'm OK with it but haven't tested it yet. ------------------------------------------------------------------------ Thu, 11 Aug 2005 18:54:22 +0000 : drumm I think this can only make the form converting job easier. Lets go ahead and put this patch in once reviewed unless anyone working directly on the new form api objects. ------------------------------------------------------------------------ Sat, 13 Aug 2005 22:34:59 +0000 : killes@www.drop.org Dries, please commit I can't bear it to see that crufty code in Drupal.
participants (5)
-
Dries -
drumm
-
Jose A Reyero
-
killes
-
Robin Monks