Issue status update for http://drupal.org/node/23620 Project: Drupal Version: cvs Component: comment.module Category: bug reports Priority: normal Assigned to: Robin Monks Reported by: Robin Monks Updated by: Robin Monks Status: patch Attachment: http://drupal.org/files/issues/Comment.Control.hardcode..patch (3.96 KB) Drumm hath found another bug... Robin Robin Monks Previous comments: ------------------------------------------------------------------------ May 25, 2005 - 22:09 : Robin Monks Attachment: http://drupal.org/files/issues/Comment.Control.hardcode.patch (4.02 KB) This patch removes all those nasty hard coded forms from comment.module's user Comment Control. Robin ------------------------------------------------------------------------ May 25, 2005 - 22:16 : Robin Monks Oh, and I've test this, and it works. Robin ------------------------------------------------------------------------ May 25, 2005 - 22:26 : Robin Monks Attachment: http://drupal.org/files/issues/Comment.Control.hardcode_0.patch (3.96 KB) A bug I missed (thanks UnConeD!). Robin ------------------------------------------------------------------------ May 25, 2005 - 23:44 : drumm I read over the code quickly and this caught my eye: + $filter = db_fetch_object($result); + $filter[0] = t('-- threshold --'); Even though PHP might not complain we should prolly decide on array or object. ------------------------------------------------------------------------ May 26, 2005 - 11:16 : Robin Monks Attachment: http://drupal.org/files/issues/Comment.Control.hardcode_1.patch (3.96 KB) Good point, I missed that. Robin