Re: [development] Have you ever laughed fate in the face?
On Jul 24, 2006, at 6:00 AM, Gabor Hojtsy wrote:
IMHO what Dries suggested with the status column is simple. status = 1 is already in queries. status = 0 means unpublished, another status can mean deleted. No need to modify queries (just review existing ones for the status queries).
once again, let me reiterate that this is an insufficient solution-- it only applies to nodes, and there are other forms of content that need to be addressed--not to mention that afaik node dependent tables don't have a status column, which could also cause problems.
On 24 Jul 2006, at 17:53, Chad Phillips -- Apartment Lines wrote:
On Jul 24, 2006, at 6:00 AM, Gabor Hojtsy wrote:
IMHO what Dries suggested with the status column is simple. status = 1 is already in queries. status = 0 means unpublished, another status can mean deleted. No need to modify queries (just review existing ones for the status queries).
once again, let me reiterate that this is an insufficient solution-- it only applies to nodes, and there are other forms of content that need to be addressed--
The main candidates would be nodes, comments and users and they all have a status field today. This should make 95% of the users happy. What else do you want to un-delete? Is it worth to be able to un-delete, say, a path alias? Loosing a path alias is not big of a data loss, and re-creating the path alias is nearly as fast as un-deleting it. Of course, it would be nice if we could undelete path aliases so we can make that happen in incremental patches; just add a status field to the table, and add an undelete action to the operations column (or something).
not to mention that afaik node dependent tables don't have a status column, which could also cause problems.
I don't see why node-dependent tables need their own status field. They implicitly inherit the node's status value (through SQL joins). Can you think of a concrete example of where/when this would be a problem? I can't think of any ... -- Dries Buytaert :: http://www.buytaert.net/
Op dinsdag 25 juli 2006 10:35, schreef Karoly Negyesi:
What about locale strings?
.. And vocabularies? And terms? And blocks? And menu items? And node-types? And lets not forget all the contribs. Deleting content-types in CCK, or views in Views. Are we really going to put a WHERE on collection of each of these objects? They are called a lot. Generalising may seem overkill, but I am sure we can find a gazillion places where we would love to have undelete features, but where an extra column brings a lot of overhead. Bèr -- [End user Drupal services and hosting | Sympal.nl ] Written while listening to time test by Benfay on thn012
Seems like there are few different visions of what this thing is. I'm all for the simpler node, users and comments only undelete feature (since I mostly only provide this access to end users). I can see the beauty and power of a full sql-based undo feature (and it makes me think about the whole staging discussion earlier), though it also makes me shiver with fear about the scalability of such a thing on a busy site, and how much mysql overhead it might be generating. For that kind of rollback, i'd depend more on daily sqldumps, I think. - Alan On 7/25/06, Bèr Kessels <ber@webschuur.com> wrote:
Op dinsdag 25 juli 2006 10:35, schreef Karoly Negyesi:
What about locale strings?
.. And vocabularies? And terms? And blocks? And menu items? And node-types? And lets not forget all the contribs. Deleting content-types in CCK, or views in Views. Are we really going to put a WHERE on collection of each of these objects? They are called a lot.
Generalising may seem overkill, but I am sure we can find a gazillion places where we would love to have undelete features, but where an extra column brings a lot of overhead.
Bèr -- [End user Drupal services and hosting | Sympal.nl ] Written while listening to time test by Benfay on thn012
-- Alan Dixon, Web Developer http://alan.g.dixon.googlepages.com/
participants (5)
-
Alan Dixon -
Bèr Kessels -
Chad Phillips -- Apartment Lines -
Dries Buytaert -
Karoly Negyesi