The new menu system -- where we are, what works and what's not
Hi, First of all, read the new menu documentation please. http://drupal.org/node/102338 Please note that everything the menu documentation talks about is intented to work. So if you browse to a page, you should see the page you wanted and the relevant access check must happen. So please give this some thought: "will I be able to upgrade my module to this system"? If you only give this thought when you will really upgrade your module to the new system, well past freeze I will not be able to adjust the API for you. Now is the time to get your voice heard. Also, here is a list of what's known to be broken in HEAD: -- no primary/secondary links -- no tabs -- no new administration page -- if you build a chain of paths like: foo/bar , foo/bar/this, foo/bar/this/that where ony foo/bar/this is a visible link then expect inheritance rules to not work. Core has no such thing IMO. -- if you give permission to role to a link without giving permission to its parents then that link for said permission will be mostly unreachable. There is no point for submitting patches for any of them as the current visible link solution will go down the drain pretty soon. Thanks for bearing with me, Karoly Negyesi
Karoly, Op woensdag 24 januari 2007 18:31, schreef Karoly Negyesi:
First of all, read the new menu documentation please. http://drupal.org/node/102338
Yust wanted to say a public "Thank you", for this very clear and wellwritten piece of documentation! clearly you did not only spend a lot of time and effor on the code, you spent a lot of time on explaining that code to others too. Way to go! Bèr -- Drupal, Ruby on Rails and Joomla! development: webschuur.com | Drupal hosting: www.sympal.nl
Yust wanted to say a public "Thank you", for this very clear and wellwritten piece of documentation! clearly you did not only spend a lot of time and effor on the code, you spent a lot of time on explaining that code to others too. Way to go!
Thanks. I did not want another form API situation and I will do everything to avoid it. Hence the phases, for example. Those who have followed the issue saw that the documentation went up days before the patch. Later, the hardest part, the map callback / arguments documentation was fixed by Steven and by webchick as well. Regards NK
Great work, Karoly! Can you please provide us with the URLs of the issues for stage 2 of the new menu system? The sooner we can get the rest of the patches committed for this, the better. Cheers, Jaza. On 1/25/07, Karoly Negyesi <karoly@negyesi.net> wrote:
Hi,
First of all, read the new menu documentation please. http://drupal.org/node/102338
Please note that everything the menu documentation talks about is intented to work. So if you browse to a page, you should see the page you wanted and the relevant access check must happen. So please give this some thought: "will I be able to upgrade my module to this system"? If you only give this thought when you will really upgrade your module to the new system, well past freeze I will not be able to adjust the API for you. Now is the time to get your voice heard.
Also, here is a list of what's known to be broken in HEAD:
-- no primary/secondary links -- no tabs -- no new administration page -- if you build a chain of paths like: foo/bar , foo/bar/this, foo/bar/this/that where ony foo/bar/this is a visible link then expect inheritance rules to not work. Core has no such thing IMO. -- if you give permission to role to a link without giving permission to its parents then that link for said permission will be mostly unreachable.
There is no point for submitting patches for any of them as the current visible link solution will go down the drain pretty soon.
Thanks for bearing with me,
Karoly Negyesi
----- Start Original Message ----- Sent: Thu, 25 Jan 2007 09:49:19 +1100 From: "Jeremy Epstein" <jazepstein@gmail.com> To: development@drupal.org Subject: Re: [development] The new menu system -- where we are, what works and what's not
Great work, Karoly!
Can you please provide us with the URLs of the issues for stage 2 of the new menu system? The sooner we can get the rest of the patches committed for this, the better.
You mean you want to lend a hand with hook_router and hook_menu split? You are my man. The task is rather simple, we need hook_router to contain path, access_callback, access_arguments, page_callback, page_arguments, map_callback, map_arguments, title properties in a path keyed array as it is now and a hook_menu which contains definitions like: $items[] = array('path' => 'title' => 'weight' => 'type' => ...); basically, everything else that's not router + title (for now page title and menu link title are the same, but this will not be a necessity any more). I somewhat doubt this could be successfully scripted. So, either find a way to script this change or do it manually. You have only about 250 items in core. If other wants to participate, do not hesitate either. Post to http://groups.drupal.org/menu which module you are converting. Meanwhile I will code the new system. Bdragon took over the permisssions patch and that's cool. This will happen at http://drupal.org/node/73874 . Regards NK
basically, everything else that's not router + title (for now page title and menu link title are the same, but this will not be a necessity any more). I somewhat doubt this could be successfully scripted. So, either find a way to script this change or do it manually. You have only about 250 items in core.
not much time I have for this now but no need to this manually, var_export to the rescue. Later.
participants (3)
-
Bèr Kessels -
Jeremy Epstein -
Karoly Negyesi