User: frodo Branch: DRUPAL-6--1 Date: Fri, 20 Aug 2010 22:49:39 +0000 Modified files: /modules/editview CHANGELOG.txt TODO /modules/editview/includes editview.views.inc Log message: Fix #417404: Fix form caching problems with minimum cache lifetimes Make Date fields and possible other complex CCK fields work If minimum cache lifetimes have been specified, on post of a form all cached forms except the posted one get invalidated. In that case we need to rebuild the form from scratch. To do this, I had to introduce a few additional hidden variables. The fast path using the cache is always tried first. The drupal_rebuild_form function was called in a loop; the number of times depended on the position of the form. This led to corrupted CCK date fields, probably because the way a date field is stored is different from the way it is presented: the loop caused the converted dates to be converted again. According to a code comment the loop's purpose was to "Rebuild form until element IDs match originals.". I could not find any reason to do this and removing the loop did not seem to introduce problems. There may well be other CCK fields that had similar problems as the date field and that now suddenly start to work. Links: http://cvs.drupal.org/diff.php?path=contributions/modules/editview/CHANGELOG... http://cvs.drupal.org/diff.php?path=contributions/modules/editview/TODO&old=... http://cvs.drupal.org/diff.php?path=contributions/modules/editview/includes/...