Kieran Lal wrote:
Hi, any feedback edits would be appreciated.
Unless there is something about xhtml that I don't know the following is nonsense:
"Finally we must be sure to that there shouldn't be a line break before the DOCTYPE declaration, so you should immediately follow both examples with the doctype line."
The Doctype comes at the start of a document and wouldn't need to change for different sections of the site.
On Thu, 2006-04-06 at 10:27 +0100, Adrian Simmons wrote:
Unless there is something about xhtml that I don't know the following is nonsense:
"Finally we must be sure to that there shouldn't be a line break before the DOCTYPE declaration, so you should immediately follow both examples with the doctype line."
From Community MX forums (first description I could find):
Internet Explorer has an unfortunate bug involving the xml declaration. If there is anything on the first line before the doctype, IE6 will switch into "quirks" mode. This means that using an xml declaration (<?xml version="1.0" encoding="UTF-8"?>) will cause the behavior. An HTML comment, even an empty one, will do the same.
http://www.communitymx.com/content/article.cfm?page=2&cid=E2F258C46D285F...
Erik
Erik Mallinson wrote:
On Thu, 2006-04-06 at 10:27 +0100, Adrian Simmons wrote:
Unless there is something about xhtml that I don't know the following is nonsense:
"Finally we must be sure to that there shouldn't be a line break before the DOCTYPE declaration, so you should immediately follow both examples with the doctype line."
Internet Explorer has an unfortunate bug involving the xml declaration.
Yeah yeah. Give me *some* credit Eric!
Ok. so perhaps I should have been specific and said "in the context of this document this is nonsense". The doctype declaration isn't relevant to 'Customizing themes for node types, terms, sections, paths, and front page' as such.
It's true but it's not in the right place.
Adrian, Oop. Sorry. Just trying to help early in the morning. Perhaps a reference to it on another page would be appropriate? I think it's helpful information for those who are new to these techniques, though I agree that it's not in the right context here.
Erik
Adrian Simmons wrote:
Erik Mallinson wrote:
On Thu, 2006-04-06 at 10:27 +0100, Adrian Simmons wrote:
Unless there is something about xhtml that I don't know the following is nonsense:
"Finally we must be sure to that there shouldn't be a line break before the DOCTYPE declaration, so you should immediately follow both examples with the doctype line."
Internet Explorer has an unfortunate bug involving the xml declaration.
Yeah yeah. Give me *some* credit Eric!
Ok. so perhaps I should have been specific and said "in the context of this document this is nonsense". The doctype declaration isn't relevant to 'Customizing themes for node types, terms, sections, paths, and front page' as such.
It's true but it's not in the right place.
Erik Mallinson wrote:
Perhaps a reference to it on another page would be appropriate?
I'm not sure. Doctypes and IE bugs are obviously of interest to Drupal themers, but they aren't actually anything to do with Drupal. At some point you need to draw a line between documenting Drupal and documenting how to write html in the current browser landscape.
Kieran: I removed the paragraph about doctypes.
What about simply a "Browser compatibility issues" page in the themes handbook that gets linked from wherever seems logical. It would then contain things like "IE sucks so send as text/html even if your code is valid XHTML", "IE sucks and quirks mode is evil so you have to omit the XML declaration and just have the doctype", etc. (Yeah, I figure it will read like a laundry list of IE bugs, but that is the current web landscape.)
It could link to some external site for more info (there's lots of them), but it could be good to flag a few of the more common issues Drupalers run into, even if they're not Drupal-specific or Drupal-caused. People writing a Drupal theme will likely look at Drupal first, thinking it's something Drupal-weird, even if wrongly.
On 4/6/06, Larry Garfield larry@garfieldtech.com wrote:
What about simply a "Browser compatibility issues" page in the themes handbook that gets linked from wherever seems logical.
I like this idea. Either a list of good references so we don't reinvent the wheel, or if none exist our own collection of known problems.
On 4/6/06, Larry Garfield larry@garfieldtech.com wrote:
What about simply a "Browser compatibility issues" page in the themes handbook that gets linked from wherever seems logical.
Dale McGladdery wrote:
I like this idea. Either a list of good references so we don't reinvent the wheel, or if none exist our own collection of known problems.
I don't think this is the right way to go about it. We aren't in the business of teaching how to write html, or even providing links to resources to do so.
But it strikes me that a theme troubleshooting FAQ might be useful. Something like http://drupal.org/node/199 With the format:
Symptom: Possible causes: Solutions:
And as you say, linking to external resources where possible.
On Fri, April 7, 2006 4:00 pm, Adrian Simmons said:
On 4/6/06, Larry Garfield larry@garfieldtech.com wrote:
What about simply a "Browser compatibility issues" page in the themes handbook that gets linked from wherever seems logical.
Dale McGladdery wrote:
I like this idea. Either a list of good references so we don't reinvent the wheel, or if none exist our own collection of known problems.
I don't think this is the right way to go about it. We aren't in the business of teaching how to write html, or even providing links to resources to do so.
But it strikes me that a theme troubleshooting FAQ might be useful. Something like http://drupal.org/node/199 With the format:
Symptom: Possible causes: Solutions:
And as you say, linking to external resources where possible.
That would work fine. Again, the point is while that we shouldn't be in the business of teaching HTML/CSS, many people will look to Drupal first when their Drupal themes misbehave. We should have something for them to find, even if it's mostly a road sign saying "blame IE, see here for more details". :-)
--Larry Garfield
On Apr 5, 2006, at 4:21 PM, Kieran Lal wrote:
Hi, any feedback edits would be appreciated.
Thanks for all the feedback. I should have clarified that this page is a collection of the most commented page in the Drupal handbook and I took what seemed liked wisdom when writing this page. Thanks for clarifying and I'll make edits accordingly.
If you have permission feel free to edit the page directly or write an alternate version.
Cheers, Kieran
Cheers, Kieran
themes mailing list themes@drupal.org http://lists.drupal.org/mailman/listinfo/themes
-
Adrian Simmons -
Dale McGladdery -
Erik Mallinson -
Kieran Lal -
Larry Garfield