[drupal-devel] Is anybody doing any major work on subscriptionsmodule?

[Moshe Weitzman]

did a quick code review

- what is this mailqueue.module? please share.
- there are some crufty variable names. this might be a good time to 
remove them, and look for briefer ways to do stuff. this module feels 
wordy still (it always did) (e.g. $uzer, $taxa)
- if you use 'destination' instead of 'return', this code becomes 
unneeded (in HEAD):
if (isset($_GET['return'])) {
     drupal_goto($_GET['return']);
   }

- subscriptions_page() is very long. consider breaking it up into its 
own pages with menu callbacks
- a longer term goal might be to add the right API so that modules 
implement their own subscriptions. I would implement groups 
subscriptions, and likely more will arise. But I think this could 
clarify the code a lot today because the code for taxo, content, and 
user subscriptions is intermingled in a unclean way (it always has 
been). i'd like to see functions which individually listen on nodeapi() 
and add themselves to the queue if needed. subscription.module would 
then take care of processing the queue.

-moshe


On Apr 2, 2005, at 2:52 PM, Robert Douglass wrote:

> I've committed the new subscriptions module to my sandbox 
> (robertdouglass) along with a small upgrade script which converts all 
> 'blog' subscriptions to 'user' subscriptions.
>
> Thank you all for your comments and suggestions. I've implemented the 
> feature set which I described in my first mail (minus the link on the 
> user page) and screenshots can be seen here:
> http://www.webs4.com/image/tid/6
>
> I'll leave the module in my sandbox for a week or so but hope that 
> after everyone has had the chance to review it we can agree to replace 
> the existing module with this version. At that point, if dziemecki and 
> TDobes are agreeable, I'd like to become the maintainer of the module.
>
> I marked several things with //TODO: in the code so people can quickly 
> see the places that need immediate attention in the future.
>
> Looking forward to your feedback,
>
> Robert