[drupal-devel] image_import.module ready for early testing

Tim Altman web at timaltman.com
Mon Apr 4 07:25:24 UTC 2005


On Sun, 03 Apr 2005 00:32:46 +0200, Scott Courtney <scott at 4th.com> wrote:

> On Saturday 02 April 2005 17:17, Tim Altman wrote:
>> > I would very much appreciate and respect your opinions, testing  
>> reports,
>> > suggestions, and constructive criticism of my module so far.

[...]

>> - It would be nice to be able to create a new gallery from the upload  
>> page.

[...]

> Is there a way to allow similar functionality for non-free-tagging
> vocabularies? I'll check into it. I agree that it would be a useful  
> feature if
> it's practical to implement.

	I don't have the free-tagging patch installed, so that's what I was  
referring to anyway. :)

[...]

>> - The username folders under the set path should be created  
>> automatically
>> upon installation and whenever a new user is added.
>
> Good point, and something I had meant to do but forgot to add. I'll put  
> it
> in the TODO list for a future release. Not all users should have these
> directories, however -- just those who have permission to mass-import
> images using this module.

	Agreed.  I thought of writing that originally.

> The idea is a good one, but it's not quite as simple as just creating a
> directory. What I probably need to do is to create it only when the
> user actually comes into the image_import main page for the first time.
> There are also some security problems possible (too tight, not too  
> loose),
> because the default permissions on new directories created by the web
> server often don't allow ordinary users to read or write within the new
> directory. But I'm hesitant to just blithely open 777 permissions on a
> directory that is auto-created. That might rankle some sysadmins (I know
> it would not please me, for one).

	I think similar problems have been encountered with creating the 'files'  
directory when an admin first visits admin > settings.  Maybe Drupal  
should have a generic 'create directory' utility function that handles all  
the permissions automagically.

	I didn't get a chance to test your updates this weekend.  Hopefully I'll  
have some time this coming week.

-- 
Tim Altman




More information about the drupal-devel mailing list