[drupal-devel] [task] Default subjects like 'Re: Parent's subject' and a bit of code cleanup

[factoryjoe]

Issue status update for http://drupal.org/node/20477

 Project:      Drupal
 Version:      cvs
 Component:    comment.module
 Category:     tasks
 Priority:     normal
 Assigned to:  drumm
 Reported by:  drumm
 Updated by:   factoryjoe
 Status:       patch

I think I want to +1 this, but I also think that the extra clutter in
the web UI would be distracting. I think that comment titles should be
optional -- and the email notifications that go out w/o a subject
should grab the parent's subject like Drumm has done. So the real
difference that I'm suggesting here is to allow for titleless comments,
since people often write title-less comments anyway. Forcing a title
only helps w/ email integration.


Chris




factoryjoe



Previous comments:
------------------------------------------------------------------------

April 14, 2005 - 01:10 : drumm

Attachment: http://drupal.org/files/issues/comment.module_11.diff (3.9 KB)

Emails containing a comment's contents, such as those listhandler sends,
are particularly unfriendly because the default subject line, which is
often not changed, is quite arbitrary. Using 'Re: parent's subject' is
a bit better.


I did a bit of code cleanup around the lines I changed as well.




------------------------------------------------------------------------

April 15, 2005 - 15:15 : Steven

I thought the consensus was that Re subjects were evil? "Re" serves to
indicate which message replies to what in emails. With threaded support
in mail clients that's now becoming obsolete too, but in Drupal I see no
need whatsoever to imitate this bad practice.


This line:
$edit['subject'] =
truncate_utf8(decode_entities(strip_tags(check_output($edit['comment'],
$edit['format']))), 29, TRUE);


is the result of a long discussion about comment subject
autogeneration. In light of various input formats, mandatory /
disallowed subjects, this seemed like the best idea.