[drupal-devel] Re: [feature] favicon patch for themes

[Steve Dondley]

Chris Messina wrote:

>-1 for putting the favicon in drupal_get_html_head.
>  
>
Not sure what you mean here.  I didn't change the drupal_get_html_head() 
function.  Perhaps you mean for NOT putting it there?

>I also think that you should be able to upload the favicon like you
>can a logo in the theme admin section and that this should be a global
>theme setting instead of the current "enter a relative path for the
>favicon".
>  
>
I purposefully left it out until I got feedback on the smaller change 
first.  I'm worried it would get shot down for adding too much clutter.

>Chris
>
>On 4/18/05, nysus <drupal-devel at drupal.org> wrote:
>  
>
>>Issue status update for http://drupal.org/node/20809
>>
>> Project:      Drupal
>> Version:      cvs
>> Component:    theme system
>> Category:     feature requests
>> Priority:     normal
>> Assigned to:  nysus
>> Reported by:  nysus
>> Updated by:   nysus
>> Status:       patch
>> Attachment:   http://drupal.org/files/issues/favicon.patch (4.57 KB)
>>
>>Here is a patch that allows a user to manually set the path to the
>>"favicon.ico" file.  It makes a single change to the user interface: it
>>adds a text field to the "Logo image setting" section of the
>>"themes/settings" page.
>>
>>This is especially useful for sites sharing a single code base as you
>>no longer need to create a new theme just so you can have a distinct
>>favicon.ico.
>>
>>
>>nysus
>>
>>
>>    
>>
>
>
>  
>