[drupal-devel] [bug] conf_init should strip out port numbers in bootstrap.inc

[Morbus Iff]

Issue status update for 
http://drupal.org/node/19934
Post a follow up: 
http://drupal.org/project/comments/add/19934

 Project:      Drupal
 Version:      cvs
 Component:    base system
 Category:     bug reports
 Priority:     normal
 Assigned to:  chx
 Reported by:  bwooster47
 Updated by:   Morbus Iff
 Status:       patch (code needs review)
 Attachment:   http://drupal.org/files/issues/_ports_0.patch (2.25 KB)

Grr. Parens in the wrong place. Right patch attached.




Morbus Iff



Previous comments:
------------------------------------------------------------------------

Sun, 03 Apr 2005 23:07:58 +0000 : bwooster47

The latest Drupal from CVS (4.6.0) offers multisite configuration files,
but currently the conf_init function in includes/bootstrap.inc will also
include the :portnum URL specification in the directory name, which does
not seem right (and the colon character may cause problems on
Mac/Windows).


Snippet from bootstrap.inc:
 * Example for a fictitious site installed at
 * http://www.drupal.org/mysite/test/ the 'settings.php' is
 * searched in the following directories:
.....


If the site is: http://www.drupal.org:8080/mysite/test/
the same list of directories should be searched as listed in the
example in the file, and the :8080 should not be added to the directory
name (I think...)


I don't know enough PHP to submit a patch, but this is probably easy
for those who know this stuff :-)




------------------------------------------------------------------------

Fri, 08 Apr 2005 07:08:53 +0000 : chx

Attachment: http://drupal.org/files/issues/conf_init_ports.patch (768 bytes)

Here you are.




------------------------------------------------------------------------

Fri, 08 Apr 2005 11:16:52 +0000 : Dries

Won't commit.  Removing the port seems like a bad idea (I could have two
drupal sites at two different ports but otherwise identical URLs) and
adding regex' all over the map isn't advised.  If ":" is an invalid
character, then there might be more such characters.  I suggest we
replace them with '.' and that we document this behavior much like we
do with $db_url.




------------------------------------------------------------------------

Mon, 11 Apr 2005 23:25:51 +0000 : chx

Attachment: http://drupal.org/files/issues/conf_init_ports_0.patch (1.35 KB)




------------------------------------------------------------------------

Tue, 19 Apr 2005 17:03:46 +0000 : bwooster47

Regarding update #3 - does this mean the code has made it in, and will
be available in the next release?


Secondly: I follow the logic for the update, and it makes sense for
non-standard HTTP port numbers, but not sure if the logic is valid when
port 80 is used.


For example, http://yourdomain.com/ and http://yourdomain.com:80/ both
will go to the exact same page, but looks like the search for the
conf.php will be different.
Not sure if this matters...




------------------------------------------------------------------------

Mon, 01 Aug 2005 01:23:28 +0000 : killes at www.drop.org

patch still applies, my testsite kept working (is not on a non-standard
port, though).




------------------------------------------------------------------------

Mon, 01 Aug 2005 05:31:56 +0000 : Dries

I think the PHPdoc is confusing.  The second example URL is
non-existing/invalid.  Did you meant showing a configuration file?


I agree with bwooster that this gets tricky with the default port '80'.
 Do we need to discuss this some more?




------------------------------------------------------------------------

Sat, 06 Aug 2005 07:20:03 +0000 : Boris Mann

I like the period (".") character as the delimiter for ports.


If people really do tack on :80, then site admins can symlink
domain.com.80 to domain.com (much as you would need to symlink
www.domain.com to domain.com as well).


I think this is largely a documentation issue.




------------------------------------------------------------------------

Fri, 19 Aug 2005 01:27:39 +0000 : Morbus Iff

Attachment: http://drupal.org/files/issues/_ports.patch (2.25 KB)

+1. This patch is absolutely required for my home development, which is
behind an ISP that doesn't like webservers on port 80. I've attached a
new patch that fixes the doc mistake from the last patch, as well as
adds a note to the INSTALL.txt too. I'm with Boris on the :80 issue -
if a developer is using it knowingly, he should be smart enough to put
2 and 2 together.