[drupal-devel] [bug] menu.module patch

[Uwe Hermann]

Issue status update for 
http://drupal.org/node/29443
Post a follow up: 
http://drupal.org/project/comments/add/29443

 Project:      Drupal
 Version:      cvs
 Component:    menu system
 Category:     bug reports
 Priority:     normal
 Assigned to:  DFG
 Reported by:  DFG
 Updated by:   Uwe Hermann
-Status:       patch (ready to be committed)
+Status:       patch (code needs review)

Patches should be reviewed first.




Uwe Hermann



Previous comments:
------------------------------------------------------------------------

Tue, 23 Aug 2005 03:33:16 +0000 : DFG

Attachment: http://drupal.org/files/issues/menu.module.patch (2.51 KB)

Is it a feature or is it a bug-fix? A littele bit of both.


The menu system is capable of showing a menu item in the breadcrumb
while not showing it in the menu tree. This is handy (e.g.) if you have
parent-child-relationships many levels deep, and you want to reflect
this in the breadcrumb, but don't want to bloat the menu block.


Paradoxically this is currently not possible with the menu.module. You
can have either both of the flags (MENU_VISIBLE_IN_TREE,
MENU_VISIBLE_IN_BREADCRUMB) set, or none of them!


After my patch, you can make any combination of these flags:
  http://d-f-g.net/drupal-request/drupal-menu-module-change-dfg-1.png


(Info: The menu is expanded up to the last visible-in-tree item in the
trail: http://d-f-g.net/drupal-request/drupal.png)


Technical details:
- very easy changes
- t('edit') no longer binded to MENU_VISIBLE_IN_TREE
- 2 checkboxes added as you can see in the picture above. these are
handled in the same style as the "expanded" checkbox, that was
availible before.


Patch is attached - and also availible here:
  http://d-f-g.net/drupal-request/menu.module.patch