[drupal-devel] [feature] Remove ?>

[Uwe Hermann]

Issue status update for 
http://drupal.org/node/29385
Post a follow up: 
http://drupal.org/project/comments/add/29385

 Project:      Drupal
 Version:      cvs
 Component:    other
 Category:     feature requests
 Priority:     normal
 Assigned to:  chx
 Reported by:  chx
 Updated by:   Uwe Hermann
 Status:       patch (ready to be committed)

+1. This will prevent lots of questions in the forums...




Uwe Hermann



Previous comments:
------------------------------------------------------------------------

Mon, 22 Aug 2005 13:37:25 +0000 : chx

Attachment: http://drupal.org/files/issues/no_question_more_at_the_end.patch (20.22 KB)

I finally decided that it's best to remove all ?> from the end of all
files. I set this to ready to be commited as there is not a single line
of code which is modified and we have debated this to death on the devel
list.


TODO: update the coding style guidelines.




------------------------------------------------------------------------

Tue, 23 Aug 2005 01:55:21 +0000 : Uwe Hermann

Patch applies, seems to work (a quick check trying various things on a
test-site succeeded).




------------------------------------------------------------------------

Thu, 25 Aug 2005 21:13:51 +0000 : Dries

Committed to HEAD.  Marking this 'active' until the coding guidelines
have been updated.




------------------------------------------------------------------------

Fri, 26 Aug 2005 05:22:10 +0000 : chx

Attachment: http://drupal.org/files/issues/leftovers.patch (1.77 KB)

I have not patched *.php so that templates won't get hurt. But this
meant a few files are left out... here.




------------------------------------------------------------------------

Fri, 26 Aug 2005 17:11:14 +0000 : Thomas Ilsche

What do you think about leaving a comment at the end of every file like


// end tag intentionally omited