[drupal-devel] [feature] Add support for generating an RSS 0.92
feed of news aggregator items
Boris Mann
drupal-devel at drupal.org
Thu Feb 10 15:23:52 UTC 2005
Project: Drupal
Version: cvs
Component: aggregator.module
Category: feature requests
Priority: normal
Assigned to: Anonymous
Reported by: blake7
Updated by: Boris Mann
Status: patch
This patch is not about "feed unification", it adds RSS feeds for
category bundles...which have been asked about (and coded for, here in
this patch) since 4.4.
Boris Mann
Previous comments:
------------------------------------------------------------------------
July 8, 2004 - 20:11 : blake7
Attachment: http://drupal.org/files/issues/aggregator.module_0.patch (2.96 KB)
The attached patch adds support for generating an RSS 0.92 feed of the
default news aggregator page (the output of aggregator_page_last()).
This allows re-use of the Drupal aggregator in other RSS readers like
Trillian.
The patch consists of the aggregator_page_rss() function which builds
the XML output needed. It uses the existing RSS building functions
already present to construct the feed.
Note the comment about how many items are in the feed. In Drupal 4.4.x,
there was a variable "aggregator_page_limit" which represented how many
items were returned for both the HTML and RSS versions. It defaulted to
75 items. In Drupal CVS, all the HTML output is now paged through a
hard-coded limit of 20 items per page. A limit of 20 seems small for
the RSS feed, so I reverted to the old limit of 75. Would it be better
to add a new variable like "aggregator_rss_limit"?
Also, there are 2 places that the callback to aggregator_page_rss are
installed. One is in _aggregator_page_list right before the pager
output and shows up as the XML icon (like how the OPML feeds are linked
now). The other is in aggregator_menu where I try and install a menu
itme called "RSS feed". For some reason, the menu itme is not
displaying itself though I believe I am inserting it properly.
Feel free to contact me if there are any questions. Thanks!
------------------------------------------------------------------------
July 9, 2004 - 09:29 : blake7
Attachment: http://drupal.org/files/issues/aggregator.module_1.patch (2.54 KB)
Fixed the navigation menu problems mentioned above. Please consider this
patch instead of the first one.
------------------------------------------------------------------------
July 9, 2004 - 10:09 : drumm
When this functionality is added it should be able to generate feeds for
each aggregator category as well.
------------------------------------------------------------------------
July 9, 2004 - 17:22 : blake7
Attachment: http://drupal.org/files/issues/aggregator.module_2.patch (3.25 KB)
Done. The attached patch supports RSS feeds of each aggregator category
through the XML icon at the bottom exactly like the main aggregator
page.
------------------------------------------------------------------------
July 10, 2004 - 04:01 : Dries
1. $base_url . "/aggregator" . $url is incorrect. All URLs must be
constructed using url() as it is aware of clean URLs and path aliasing.
2. Emitting 75 RSS items is quite much (uncommon) and can easily turn
into a bandwidth bottleneck. Can we add one global setting that
controls how many entries our feed should have (not just the newly
introduced feeds)? To 'export' your content in case you wish to
migrate to another tool, a special value 'all' (say '1000000') might be
handy.
------------------------------------------------------------------------
September 17, 2004 - 00:19 : blake7
Attachment: http://drupal.org/files/issues/aggregator.module_3.patch (4.47 KB)
1. Using url() now.
2. Added the presistent variable aggregator_rss_limit which controls
how many RSS items are generated. A form_select edit control to control
the new variable, with all defined as 1000000, was added to the
configure tab.
I am not sure what you mean by "our feeds" versus "newly introduced
feeds" in your comment.
Also, even though the code-freeze has taken place, do you think it
would be possible to get this into Drupal 4.5? The code change is very
minimal and I believe the ability to share aggregated feeds is a great
feature.
------------------------------------------------------------------------
September 17, 2004 - 10:07 : Boris Mann
+1
I actually assumed (there was much discussion?) that the re-exporting
of aggregator items on a per-bundle basis was going to be enabled for
4.5.
Let's get this in before the code freeze -- this would be a major
feature announcement for 4.5, and could perform the basis for other
great functionality for 4.6 (e.g. per category OPML file generation).
------------------------------------------------------------------------
October 22, 2004 - 10:20 : blake7
Now that 4.5 has released. Can this go into CVS/HEAD? Is there any other
changes to the patch that need to be made by me to make that happen?
Thanks.
------------------------------------------------------------------------
October 23, 2004 - 10:05 : Dries
I'll look at it again. Does the patch add XML-icons or how do people
find out about the RSS feeds? Can't we make the URLs a bit more
intuitive? For example by making it so that you merely have to append
'/rss.xml' to the aggregator module's URLs:
foo.com/aggregator/rss.xml
foo.com/aggregator/categories/1/rss.xml
It is certainly not a requirement, just a thought that might be worth
considering.
------------------------------------------------------------------------
October 23, 2004 - 10:15 : Dries
I'll look at it again. Does the patch add XML-icons or how do people
find out about the RSS feeds? Can't we make the URLs a bit more
intuitive? For example by making it so that you merely have to append
'/rss.xml' to the aggregator module's URLs:
foo.com/aggregator/rss.xml
foo.com/aggregator/categories/1/rss.xml
It is certainly not a requirement, just a thought that might be worth
considering.
------------------------------------------------------------------------
October 25, 2004 - 02:50 : Bèr Kessels
cross linking to a [feature] that talks about such a unified rss link:
http://drupal.org/node/11937
------------------------------------------------------------------------
February 9, 2005 - 12:17 : sethcohn
Bump.
Neat feature, would be nice for 4.6
What's the progress on making it happen?
------------------------------------------------------------------------
February 9, 2005 - 12:43 : Boris Mann
Here's another bump to this. I would say since it missed 4.5 (and was
ready at the time) we get this in to 4.6.
Should mesh nicely with walkah's RSS updates.
Dries: there is an XML icon at the bottom of each category page, plus
the HTML header can include an alternate link to the feed. I vote
against any sort of "rss.xml", people can alias if they wish.
(ideally we could get per-category OPML links as well, but I'll leave
that for another feature request)
------------------------------------------------------------------------
February 10, 2005 - 06:58 : Bèr Kessels
A request for unification of feeds [1] is waiting in the queue already.
[1] http://drupal.org/node/11937
--
View: http://drupal.org/node/9167
Edit: http://drupal.org/project/comments/add/9167
More information about the drupal-devel
mailing list