[drupal-devel] Internationalization, Usability and changes in the coding conventions

[Carl McDade]

Second guessing but,

Can someone tell me why this is like this:

print theme("page", message_access(), t("Access denied"));

rather than this?

print theme("page", t('Please login or register to see this material'),
t("Access denied"));

Why is there a call to a Function like this anyway? Is is a mistake in
the filestore2 module or is this something that has to be used? I
noticed this after killes posted. Is this legacy code and should be removed?

Carl McDade

Carl McDade wrote:
> I had forgotten about the use of t() but that is not a problem when 
> diog
> this. Since the common.inc is not involved any longer the pratical use
> of t() and in keeping with the use of gettext in the contrib module
> would be:
> 
> print theme("page", message_access(t('Please login or register to see
> this material')), t("Access denied"));
> 
> This means that the core item common.inc only has to be changed once to
> allow for the (default or variable) and would never need a PO file or
> gettext. This is a pick up in performance for common.inc that offsets
> any losses for a call to a string variable.
> 
> Carl McDade
> 
> 
> Bèr Kessels wrote:
>> 1) whats wrong with t()? Its the default in a lot of environments, 
> its 
>> use has 
>> been weighted, and proven bets.
>> 2) if you encounter any non-translated strings, that is  a bug. 
> Please 
>> report 
>> these bugs.
>> 
>> Bèr
>> 
>