[drupal-devel] [feature] Small fix for conf.php.

Bèr Kessels drupal-devel at drupal.org
Mon Feb 28 12:42:27 UTC 2005


Issue status update for http://drupal.org/node/11645

 Project:      Drupal
 Version:      cvs
 Component:    base system
 Category:     feature requests
 Priority:     normal
 Assigned to:  Chris Johnson
 Reported by:  Uwe Hermann
 Updated by:   Bèr Kessels
 Status:       patch
 Attachment:   http://drupal.org/files/issues/db_hostname.patch (550 bytes)

+1 from me. This very small change makes it very clear that we do not
want the hostname of the server, but of the database.
One small question: in drupal we use underscores to mark words
everywhere (functions, variables, modules, themes etc.) so can you use
db_hostname?
Attached patch does that.


Bèr Kessels



Previous comments:
------------------------------------------------------------------------

October 16, 2004 - 14:11 : Uwe Hermann

As seen here [1] it's not so obvious what to fill into the $dburl line
in include/conf.php.
My suggestion to clarify this a bit:
Replace
# $db_url = "mysql://user:password@hostname/database";
with
# $db_url = "mysql://dbuser:dbpassword@dbhostname/database";
This should make it a little clearer that the database user, password
and host is meant.
The same should be done with the PostgreSQL line...
[1] http://drupal.org/node/11325#comment-17968


------------------------------------------------------------------------

February 24, 2005 - 16:31 : Chris Johnson

Attachment: http://drupal.org/files/issues/conf.php.patch (579 bytes)

Here's a simple patch against 4.5.2.


------------------------------------------------------------------------

February 24, 2005 - 16:35 : Chris Johnson

Attachment: http://drupal.org/files/issues/settings.php.patch (551 bytes)

And here is the equivalent patch for HEAD, against settings.php.


------------------------------------------------------------------------

February 24, 2005 - 18:27 : tangent

Makes sense to me. +1





More information about the drupal-devel mailing list