[drupal-devel] [bug] Do not allow anonymous comment info editing if disabled

Goba drupal-devel at drupal.org
Tue Jul 19 19:32:20 UTC 2005


Issue status update for 
http://drupal.org/node/26516
Post a follow up: 
http://drupal.org/project/comments/add/26516

 Project:      Drupal
 Version:      4.6.2
 Component:    comment.module
 Category:     bug reports
 Priority:     normal
 Assigned to:  Goba
 Reported by:  Goba
 Updated by:   Goba
 Status:       patch

This needs to get fixed in 4.6.x, unless you intend to release no
further 4.6.x versions. Otherwise I have no HEAD to test, but looked
through the patch, and it seems that it adequately replaces the admin
comment edit form with the usual comment edit form (which seems to be a
straightforward thing to do anyway :)




Goba



Previous comments:
------------------------------------------------------------------------

Thu, 07 Jul 2005 11:50:13 +0000 : Goba

Attachment: http://drupal.org/files/issues/Drupal.anonymous-comment-edit.patch (813 bytes)

The comment_admin_edit() admin editing interface allows the admin to
edit anonymous comment sender properties, but this option is also
provided when this feature is explicitly disabled on the settings page,
and such info should not be stored. The attached patch checks if the
option is not disabled and only allows editing in that case.


This is also a bug in DRUPAL HEAD.




------------------------------------------------------------------------

Mon, 18 Jul 2005 21:22:28 +0000 : moshe weitzman

this whole function is removed by http://drupal.org/node/18656. i
suggest waiting for that aptch to land (soon i hope).




------------------------------------------------------------------------

Tue, 19 Jul 2005 18:55:23 +0000 : Dries

Moshe's patch landed.  Do we still need to fix this in HEAD, or can this
issue be closed?  Care to test/validate?







More information about the drupal-devel mailing list