[drupal-devel] [bug] Don't import global $theme in bluemarine's page.tpl.php

Dries drupal-devel at drupal.org
Sat Jul 30 14:05:49 UTC 2005


Issue status update for 
http://drupal.org/node/27784
Post a follow up: 
http://drupal.org/project/comments/add/27784

 Project:      Drupal
 Version:      cvs
 Component:    theme system
 Category:     bug reports
 Priority:     normal
 Assigned to:  robertDouglass
 Reported by:  robertDouglass
 Updated by:   Dries
 Status:       patch

Is there any theme that uses the $theme variable?  Only bluemarine seems
to be using it and according to http://drupal.org/node/27791 it might be
dead code.




Dries



Previous comments:
------------------------------------------------------------------------

Fri, 29 Jul 2005 17:07:53 +0000 : robertDouglass

Attachment: http://drupal.org/files/issues/global_theme_patch.txt (1.9 KB)

It seems like bad style to use <?php global $theme ?> in .tpl.php files.
If $theme is needed in the page template, let's send it in as a variable
so that it is consistent across all themes.







More information about the drupal-devel mailing list