[drupal-devel] [feature] I added few error messages

[kubaZygmunt]

Issue status update for 
http://drupal.org/node/27695
Post a follow up: 
http://drupal.org/project/comments/add/27695

 Project:      Drupal
 Version:      cvs
 Component:    taxonomy.module
 Category:     feature requests
 Priority:     normal
 Assigned to:  Anonymous
 Reported by:  kubaZygmunt
 Updated by:   kubaZygmunt
 Status:       patch (code needs review)
 Attachment:   http://drupal.org/files/issues/taxonomy.module.patch.txt (7.04 KB)

Ok, I've updated these functions, improved my style and changed a little
code which prevents from deleting voc. and terms after changing name to
0.


1.
Changing name to '0' (single number) causes that the condition:

<?php
if ($edit['vid'] && $edit['name'])
?>


will fail.


2. There was an error in taxonomy_del_term() function which gives
error/warning message.




kubaZygmunt



Previous comments:
------------------------------------------------------------------------

Thu, 28 Jul 2005 16:13:23 +0000 : kubaZygmunt

Attachment: http://drupal.org/files/issues/taxonomy_3.module (52.92 KB)

During writing my test for Drupaltest I saw that we don't have error
messages in taxonomy module, so you can add taxonomy with empty name!!
:)
I've added something which prevent from this




------------------------------------------------------------------------

Thu, 28 Jul 2005 16:22:05 +0000 : kubaZygmunt

Attachment: http://drupal.org/files/issues/taxonomy_10.patch (5.24 KB)

I added diff patch




------------------------------------------------------------------------

Fri, 29 Jul 2005 07:17:59 +0000 : Dries

Please resubmit without tabs and proper coding conventions.  Thanks.




------------------------------------------------------------------------

Fri, 29 Jul 2005 17:06:45 +0000 : Steven

Putting all these tests into separate functions is a bit too much IMO.