I've rewritten the patch reviewing guidelines. I've tried to point out what you should be asking yourself when doing a review as well as describing some good practices that I've found help. Though it also doubles as a "should I submit my patch" guide, basically ;). http://drupal.org/node/772 Steven