[drupal-devel] [bug] Consistency in form elements form_autocomplete(), form_textfield() and form_textarea()

Dries drupal-devel at drupal.org
Mon Jun 27 18:33:32 UTC 2005


Issue status update for http://drupal.org/node/25603

 Project:      Drupal
 Version:      cvs
 Component:    base system
 Category:     bug reports
 Priority:     normal
 Assigned to:  stefan nagtegaal
 Reported by:  stefan nagtegaal
 Updated by:   Dries
 Status:       patch

Committed to HEAD.  I suggest we document the defaults in the PHPdoc
comments.  Guidelines are in order to avoid inconsistency creeping in. 
I'm not marking this fixed yet.




Dries



Previous comments:
------------------------------------------------------------------------

June 23, 2005 - 14:53 : stefan nagtegaal

Attachment: http://drupal.org/files/issues/form_size_consistency.patch (69.9 KB)

Attached you'll find the patch for making the form element,
form_field(), form_autocomplete() and form_textarea() consistent in
size..


I used:


form_autocomplete() and form_textfield():
for numbers: width of 5;
for small textfields: width of 15 or 30;
for textfields settings, titles etc: width of 60;


form_textarea()
small textarea's: width 60, height 5 rules;
medium textarea's: width 60, height 15 rules;
large textarea's (node submission body's): width 60, height 20 rules;


please review and apply patch... I this is - for the sake of
consistency - a very fine patch..




------------------------------------------------------------------------

June 27, 2005 - 18:50 : wnorrix

I think this is a good idea, good way to standardize the UI.


+1







More information about the drupal-devel mailing list