[drupal-devel] warnings for bootstrap.inc and common.inc

Negyesi Karoly karoly at negyesi.net
Tue Mar 1 08:56:11 UTC 2005

> > common.inc:
> >
> > error_handler, line 379 the parameter $variables seems to be not used
> > in this function
> +/-1. The error_hanlder() function is a PHP callback set using
> set_error_handler().  Consult PHP's documenation on set_error_handler()?


The fifth parameter is optional, 

As we do not use it, and it is optional anyways, I say, let it go.

> > _fix_gpc_magic, line 392 $key is not used.
> +1. Looks like $key can be removed.
> > form_file, line 1354 $error is used but I have not seen where it is
> > initialized. Maybe this should be $name?
> +1. $error should be $name.  That would be a bug.

I'll submit a two line patch for these, OK.

> > Shall I continue with more files?
> Sure, but filter out the false positives.

I will do my best.



More information about the drupal-devel mailing list