[drupal-devel] [feature] please include the bidi.module as a standard module

alaa drupal-devel at drupal.org
Sat Mar 26 20:30:47 UTC 2005


Issue status update for http://drupal.org/node/13829

 Project:      Drupal
 Version:      cvs
 Component:    base system
 Category:     feature requests
 Priority:     normal
 Assigned to:  Anonymous
 Reported by:  Anonymous
 Updated by:   alaa
 Status:       active

the code is already in my sandbox but as Steven demonstrated its a
horrible hack and not really ready to be a proper module.
I never got around to cleaning it or any of the other EGLUG modules up.


alaa



Previous comments:
------------------------------------------------------------------------

December 3, 2004 - 03:39 : Anonymous

please include the bidi.module as a standard module, which could be
found here:
http://uniball.dyndns.org/cgi-bin/viewcvs.cgi/www/eglug/modules/bidi.module
This is needed to make arabic function correctly.


------------------------------------------------------------------------

January 14, 2005 - 17:40 : killes at www.drop.org

moving to Drupal.


------------------------------------------------------------------------

March 14, 2005 - 21:04 : kbahey

To the original author of the bidi.module:
Please commit it to the contrib respository, and create a project page
for it. This way everyone can get it.


------------------------------------------------------------------------

March 21, 2005 - 18:09 : Steven

This is in fact not needed at all for Arabic. It is needed to /mix/ two
languages with different text directions. This is a different thing
altogether.
The code seems a bit excessive to me: you should use regular
expressions for speed, as well as use Unicode character ranges instead
of byte-based regexps (use the /u modifier). Finally, the filter
settings should be removed, as they are not settings at all. This
practice was removed in 4.5.
Also, I'm not sure about the setlocale() call. In my tests, PHP seems
to ignore the locale for almost everything.


------------------------------------------------------------------------

March 26, 2005 - 22:27 : msameer

kbahey, Alaa is the original author of the module, It's in his sandbox
in the drupal CVS.
I just ported it to drupal 4.5 API.
Infact the module isn't that clean. Alaa is sitting in front of me ATM
and he'll reply to this issue.
Best regards,





More information about the drupal-devel mailing list