[drupal-devel] drupal.css, again (still)

Wed May 18 15:51:41 UTC 2005

How about we change the drupal_get_html_head() function so that it does 
not inject the drupal.css file. instead, core themes and themes that 
want this file add that line to their <head> section manually. themes 
that don't want it simply omit this include.

-moshe

Bèr Kessels wrote:
> A lot has been discussed about this, but as of yet nothing solved.
> 
> Can we discuss this, **but with the aim to come to an agreement?**
> 
> Personally I am really annoyed by the drupal.css and remove it nearly always. 
> But it is correct to state that drupal.css must be there, for usability sake. 
> A lot of (especially admin) pages will not work without some CSS.
> 
> But that is definitely no excuse for all sorts of background-colors, 
> font-sizes, borders etc, that are in that sheet.
> 
> So, to get to a conclusion; I think we should *not* discuss whether or not 
> drupal.css must be there, we will never come to an agreement on that. it will 
> remain, unless someone patches a very nice solution. 
> 
> But we should discuss what can be in there and what not! 
> My first idea is, drupal.css must contain
> * No colours, nor background colours, unless they greatly enhance useability. 
> think of watchdog entries. But not tables, grey tables are nice, but should 
> be styled by the theme;
> * No borders, paddings or margins, *unless* a page will break without them [1]
> * No floats, breaks, displays, centres or other things that manipulate the 
> flow, *unless* a page will break without them. [2]
> * No widths, unless they are really needed to make floated erlements appear on 
> the same line. with:100% is very annoying due to the famous border-box-model.
> 
> [1]
> usefull:
> ul.primary li.active a {
>   background-color: #fff;
>   border: 1px solid #bbb;
> 
> annoying:
> .tips {
>   margin-top: 0;
>   margin-bottom: 0;
> 
> [2]
> usefull:
> br.clear {
>   clear: both;
> }
> annoying:
> #aggregator .news-item .date {
>   float: left;
> }
> or even more annoying
> .user-login-block {
>   text-align: center;
> }
> 
> Regards,
>  Bèr