[drupal-devel] [feature] Fix problems with node attribute checking (and improve defaults)

[Steven]

Issue status update for http://drupal.org/node/24003

 Project:      Drupal
 Version:      cvs
 Component:    forum.module
 Category:     feature requests
 Priority:     normal
 Assigned to:  Steven
 Reported by:  Steven
 Updated by:   Steven
 Status:       patch
 Attachment:   http://drupal.org/files/issues/forumpromote_0.patch (2.57 KB)

Okay this patch is now a little different ;). It fixes the checking of
attributes in blogapi: not only was the default for the variable wrong,
but it also checked for array keys rather than array values.


Finally, I fixed the database.sql fix so it correctly makes forum
topics not be promoted by default.




Steven



Previous comments:
------------------------------------------------------------------------

May 31, 2005 - 18:52 : Steven

Attachment: http://drupal.org/files/issues/forumpromote.patch (1.14 KB)

One side effect of the node system is that all the default node flags
(promote, revisions, etc) have only one default setting for all node
types.


The most meaningless result of that IMO is that forum topics are
promoted to the front page by default. This is probably one of the most
confusing things people run into when setting up a Drupal forum.


The attached patch adds a row to the variable table to force forum
topics to not be promoted by default. This will only affect new
installations.


Patch is for CVS, but IMO it should go in 4.6 too.




------------------------------------------------------------------------

May 31, 2005 - 20:32 : Steven

Sorry I based this on a quick glance at my variables table which seemed
to be stale. But I've noticed a problem with the way node options are
checked in blogapi. Better patch coming.