[drupal-devel] I do not care about PHP 5
Larry Garfield
larry at garfieldtech.com
Sun Oct 16 20:20:09 UTC 2005
On Sunday 16 October 2005 05:42 am, Gabor Hojtsy wrote:
> > I do agree that more complete coding guidelines (objects vs. arrays, when
> > to pass what, optimal way to check for variable existence, etc.) are a
> > good idea.
>
> Per issue patches.
>
> 1. Identify a problematic practice.
> 2. Fix all occurances of this single practice.
> 3. Submit a patch for the code.
> 4. Submit a patch for the coding guidelines.
>
> *. Iterate from (1) with another problematic practice.
>
> It is much easier to focus on one problematic practice, when creating
> and reviewing patches.
>
> Goba
I agree, generally, but fix to what? We should decide whether we're going to
standardize on is_null() or === NULL before we start writing patches to
always use one or the other, for instance.
--
Larry Garfield AIM: LOLG42
larry at garfieldtech.com ICQ: 6817012
"If nature has made any one thing less susceptible than all others of
exclusive property, it is the action of the thinking power called an idea,
which an individual may exclusively possess as long as he keeps it to
himself; but the moment it is divulged, it forces itself into the possession
of every one, and the receiver cannot dispossess himself of it." -- Thomas
Jefferson
More information about the drupal-devel
mailing list