[drupal-devel] [bug] Remove PHP5 warnings about unassigned variables and functions being used

[m3avrck]

Issue status update for 
http://drupal.org/node/30800
Post a follow up: 
http://drupal.org/project/comments/add/30800

 Project:      Drupal
 Version:      4.6.3
 Component:    base system
 Category:     bug reports
 Priority:     normal
 Assigned to:  Anonymous
 Reported by:  fgm
 Updated by:   m3avrck
 Status:       patch (code needs work)

fgm, I changed the status on this to CVS since this bug exists in *both*
CVS and 4.6.3. To the best of my knowledge, patches like this will only
be incorporate in HEAD since they don't adversly affect 4.6.3. However,
to keep this distinction clear, I've created a new patch for HEAD, found
here: http://drupal.org/node/30930  ... this patch should make it into
core for the 4.7 release, just an FYI. If you would like, we could
really use your help testing this patch for HEAD so we get right before
4.7 is released. Thanks!




m3avrck



Previous comments:
------------------------------------------------------------------------

Fri, 09 Sep 2005 20:07:16 +0000 : fgm

Attachment: http://drupal.org/files/issues/missing_isset.zip (2.38 KB)

This is a set of similar patches to several files: bootstrap.inc,
common.inc, pager.inc, devel.module, filter.module, node.module,
user.module, watchdog.module


They are all there to maintain identical functionality but remove
warnings caused by code like:


$somevar = $somearray['somekey'] ;  


where the existing code does not check whether $somearray contains an
entry for 'somekey', or even whether $somearray actually exists.


Another change in this patch conditionally restores the missing
timer_read function in devel.module, by first checking whether or not
it is already defined.


Packaged as two patches, one for the includes directory, the other for
the modules directory




------------------------------------------------------------------------

Fri, 09 Sep 2005 20:15:23 +0000 : fgm

Attachment: http://drupal.org/files/issues/includes_0.patch (2.01 KB)

Split in two patches to avoid the .zip 


First here contains the patch to includes




------------------------------------------------------------------------

Fri, 09 Sep 2005 20:15:43 +0000 : fgm

Attachment: http://drupal.org/files/issues/modules_3.patch (4.04 KB)

Second here contains patch for modules




------------------------------------------------------------------------

Fri, 09 Sep 2005 21:11:23 +0000 : m3avrck

These patches don't apply to HEAD and problem exists in HEAD as well.


A single patch should be made that fixes all of these in HEAD. I'll see
what I can do, this is a good start.




------------------------------------------------------------------------

Sat, 10 Sep 2005 19:46:14 +0000 : fgm

Don't know why it was defined against HEAD: I made it for 4.6.3, and
thought I had properly defined it for that version. Maybe it changed
when I added the separate patches as suggested by someone on IRC...




------------------------------------------------------------------------

Sun, 11 Sep 2005 12:31:47 +0000 : fgm

Attachment: http://drupal.org/files/issues/modules_4.patch (17.02 KB)

Patch for the modules directory expanded and improved. Still for 4.6.3,
not HEAD.