[drupal-devel] [bug] Comment pager not working in cvs?

[leafish_paul]

Issue status update for 
http://drupal.org/node/26031
Post a follow up: 
http://drupal.org/project/comments/add/26031

 Project:      Drupal
 Version:      cvs
 Component:    comment.module
 Category:     bug reports
 Priority:     critical
 Assigned to:  leafish_dylan
 Reported by:  leafish_dylan
 Updated by:   leafish_paul
 Status:       patch (code needs review)

Agreed on the deleting one comment only ting, here's some links:


http://drupal.org/node/11877
http://www.settingtheworldtorights.com/node/417 (search for 'delete a
single comment')




leafish_paul



Previous comments:
------------------------------------------------------------------------

Wed, 29 Jun 2005 23:43:10 +0000 : leafish_dylan

I've just upgraded a 4.6.1 site to CVS and there's no comment pager on
nodes with more than $comments_per_page. Is this a bug, or it it one of
my modules? I've tested the site with various other themes, including
the defaults.




------------------------------------------------------------------------

Mon, 04 Jul 2005 23:41:03 +0000 : leafish_dylan

Can anybody confirm this? I can't find the problem.




------------------------------------------------------------------------

Fri, 15 Jul 2005 12:35:14 +0000 : leafish_dylan

Hello?




------------------------------------------------------------------------

Tue, 23 Aug 2005 14:12:16 +0000 : Uwe Hermann

Confirmed in HEAD. The problem is here (comment.module,
comment_render()):


      if ($pager = theme('pager', NULL, $comments_per_page, 0,
array('comments_per_page' => $comments_per_page))) {
        $output .= $pager;
      }


The $pager variable is empty (for whatever reason), hence no pager is
generated. I didn't debug this any further...




------------------------------------------------------------------------

Fri, 09 Sep 2005 21:11:26 +0000 : leafish_paul

Confirmed here too - can any one take a look at this?




------------------------------------------------------------------------

Mon, 19 Sep 2005 15:52:20 +0000 : leafish_dylan

Attachment: http://drupal.org/files/issues/comment.module_30.patch (1.02 KB)

Comment paging has been broken in CVS for at least 3 months, yet only
one other person has noticed this? 


Here's a patch to fix the bug...




------------------------------------------------------------------------

Mon, 19 Sep 2005 17:21:36 +0000 : tostinni

I also posted a patch there [1].
But there's still some major bug with comments...
[1] http://drupal.org/node/26966#comment-41012




------------------------------------------------------------------------

Mon, 19 Sep 2005 23:00:56 +0000 : leafish_dylan

Oh, okay. I wish I'd seen your patch before I hunted this bug down
myself, but thanks anyway.


You're right, the comment module is very broken right now. Most of the
problems are related to the pager or the comment options box, but there
are limitations with this module that are really quite suprising. Can we
still not delete a single comment in a thread, for example? This is
evil, and wrong.