[development] check_markup() question

Gordon Heydon gordon at heydon.com.au
Wed Apr 12 23:02:29 UTC 2006


On Wed, 2006-04-12 at 08:49 -0400, Moshe Weitzman wrote:
> Many folks have also advocated for this so you are in good company. Since
> Steven will have to bless this patch, I suggest getting buy in from him on a
> use case. See his comment at
> http://www.acko.net/blog/drupal-filter-formats#comment-78

This was an interesting read, and I think replicates the system that is
currently here. I think that the filter system is great, but if it is
context based, we can have a much clean UI and will allow developers to
use filters in more places without adding unnecessary information to
other parts of the system.

eg. If I was to make a E-Commerce Transaction filter to allow adding of
additional information on emails that are sent out, which the filter
system would be perfect for, would just be additional junk that a user
doesn't need to see when creating creating a node. 

> Also see an old patch at http://drupal.org/node/11225. There may be others
> around too.

I have taken a look at this patch and it is similar to what I want, but
it need to be a lot more generalised.

ATM this patch makes it a lot more node orientated, where I would like
to a lot more generic so that it can be used a lot more throughout the


> On 4/12/06 2:21 AM, "Gordon Heydon" <gordon at heydon.com.au> wrote:
> > Hi,
> > 
> > On Tue, 2006-04-11 at 09:53 +0200, Bèr Kessels wrote:
> >> Op maandag 10 april 2006 01:40, schreef Gordon Heydon:
> >>> Also is it possible to have a filter that is allowed only in certain
> >>> situations as I would like to turn all the ecommerce emails into
> >>> filtered fields, but this does not really relate to a node at all.
> >> 
> >> You may want to look at blocks. They are not node (ugh) and still use the
> >> filters. 
> > 
> > I have taken a look at this, and it was what I expected.
> > 
> > check_markup() is good if you want to call it in total isolation, ie so
> > what is contained within the content don't really need to know where it
> > is being called from.
> > 
> > In the case of a node with php content you can generally work out what
> > the node is and do a node load to get the data. By this is really a
> > little inefficient, because before calling the check_markup() from
> > node_prepare() we already have the node object, so it would be nice if
> > you can have the $node as a local variable so that you can use it.
> > 
> > Also with the filters it would be nice if they can be more content type
> > oriented. I would like to be able to classify filters so that they only
> > get used on certain types of content. So the current filters would be
> > considered a global filters and would appear on everything, but for
> > E-Commerce I could create a transaction filter class and this will only
> > be display on the emails that are sent from ecommerce, and not in other
> > areas like nodes.
> > 
> > Also when the filters are getting run we would be able to pass through a
> > an array of variables which can be used by the filters.
> > 
> > I think that I have my 4.8 project.
> > 
> > What do people think.
> > 
> > Thanks in advance.
> > Gordon.
> > 
> !DSPAM:1000,443cfa98140941299430736!

More information about the development mailing list