[development] Re: [drupal:dries] /modules contact.module
drupal-devel at istyledthis.nl
Sat Jan 14 18:24:02 UTC 2006
IMO this patch introduced even more inconsistencies in core than we
Look at the way this patch dealed with HTML-tags inside the _help().
We never did that this way..
%category is IMO user submitted data, which is NOT translatable
through drupal! It isn't now, and should never be wrapped through t().
I heared someone complain lately about bad reviewing of patches, but
this isn't an excellent example either!
C'mon Dries, why in Gods name did you applied this patch???
Op 14-jan-2006, om 11:33 heeft drupal-devel at drupal.org het volgende
> User: dries Branch: HEAD Date: Sat, 14 Jan 2006 10:33:22 +0000
> Modified files:
> /modules contact.module
> Log message:
> - Patch #39135 by Zen: various contact form improvements/fixes.
> + Conversion to _validate + _submit model..
> + Split replaced by explode - faster
> + Fixed typos: Recipient
> + Fixed weight defaulting to -10
> + Popped mail subject formatting into a t()
> + Popped '--' formatting into a t()
> + Does a lot of documentation fixing/rewriting.
> + Renamed contact_user_mail form functions to contact_mail_user
> for consistency.
> + ...
> [ Drupal cvs list | http://list.drupal.org/ ]
Drupal-Devel at iStyledThis.nl
Drupal Development Mailinglist
More information about the development