[development] coding standard question
Steve Rude
steve at achieveinternet.com
Mon Aug 27 18:17:31 UTC 2007
According to this: http://drupal.org/node/121388 lowercase is faster,
but we should make a decision, and document it in the coding standard.
I just find it confusing for our entry to mid-level developers to have
the coder module saying one thing and the code everywhere saying
something else...
I was correcting them about using lowercase instead of uppercase when I
found out the coder module was telling them something else entirely.
David Strauss wrote:
> I personally prefer uppercase because it's more consistent with other
> constants. What source says lowercase is faster?
>
> Steve Rude wrote:
>
>> So I was trying to research a coding standard that I don't see
>> documented anywhere.
>> What is the standard about NULL, TRUE and FALSE. According to the coder
>> module it says to use lowercase because it is faster, but throughout
>> core there is uppercase.
>>
>>
>> e.g. in the system.module (not to mention the trailing comma is missing...)
>>
>> /**
>> * Implementation of hook_menu().
>> */
>> function system_menu($may_cache) {
>> $items = array();
>>
>> if ($may_cache) {
>> $items[] = array('path' => 'system/files', 'title' => t('File
>> download'),
>> 'callback' => 'file_download',
>> 'access' => TRUE,
>> 'type' => MENU_CALLBACK);
>>
>> I know this is a very minor point, but we are trying to match our
>> internal coding standards with that of Drupal.
>>
>> Thanks!
>>
>> Steve Rude
>>
>
>
--
Steve Rude + Lead Developer
*AchieveInternet*
(800) 618-877 x 202
http://www.achieveinternet.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.drupal.org/pipermail/development/attachments/20070827/2d7a593e/attachment.htm
More information about the development
mailing list