[development] RTBC - how does it work?

[Gerhard Killesreiter]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Khalid Baheyeldin schrieb:
> On 7/1/07, Doug Green <douggreen at douggreenconsulting.com> wrote:
>>
>>  I searched the docs and couldn't find the protocol for this.  How does a
>> patch get to be RTBC?  Is this a peer review thing or is it limited to a
>> handful of people.   The only thread I found was this one, which is
>> clearly
>> a work-in-progress, and one that we've moved past:
>> http://lists.drupal.org/pipermail/development/2005-August/007431.html.
>>
> 
> Peer review by those who test it and find it works.

"It works" isn't all that's needed. It should follow the coding style as
well as being done "the Drupal way"(tm).

> Definitely not limited to a chosen few.

Well, of course anybody can set the status to rtbc. But since a core
committer will look at who set it to that status, it will help if
somebody does it who is known to not lightheartedly set everything to
rtbc just because he likes the feature. It also helps if the person who
sets the status has a known experience in the area the patch addresses.

So, indeed in some sense it is limited to a few, though these aren't
really chosen in some way.

The status of a "trustworthy patch reviewer" can be earned. It is a lot
of hard work.

Cheers,
	Gerhard

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFGiKl/fg6TFvELooQRAvttAJ9bYWDcnk1qeJkO4UU7+2Ro+nvkQwCfWSoR
8KWBr92cahuVaL7TtiiL4Uc=
=VCKt
-----END PGP SIGNATURE-----