[development] Coder Style review to RTBC (was RTBC - how does it work?)

[Doug Green]

There's been mention of style.pl, but IMHO coder does a better job.  Am I
reading that a hookable version of the coder style review has potential to
being plugged into the RTBC process?  If so, I'll create an issue to gather
people's ideas on how this should work.  

I'm thinking that the system would need to checkout the latest head, apply
the patch, run a hookable version of the coder style review, return a status
(TRUE/FALSE or ranking 1-10, 10 being good), and store the full text results
for display.  This probably shouldn't be done on the d.o architecture for
performance reasons.

Doug Green
904-583-3342
www.douggreenconsulting.com
 
Bringing Ideas to Life with Software Artistry and Invention...
Providing open source software political solutions
-----Original Message-----
From: development-bounces at drupal.org [mailto:development-bounces at drupal.org]
On Behalf Of Gerhard Killesreiter
Sent: Monday, July 02, 2007 4:01 AM
To: development at drupal.org
Subject: Re: [development] RTBC - how does it work?

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

adrian rossouw schrieb:
> 
> On 02 Jul 2007, at 9:30 AM, Gerhard Killesreiter wrote:
> 
>>
>> "It works" isn't all that's needed. It should follow the coding style as
>> well as being done "the Drupal way"(tm).
> 
> Can't we force patches to be run through code-style.pl before being
> considered for committing ?

IIRC there is a SoC projcet which deals with issues like this. But
frankly: Coding style is usually the least issue with a patch.

Cheers,
	Gerhard
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFGiLCqfg6TFvELooQRAiN6AJ9/TySxMWxb5Tyd4WkXBQWeFy+N3QCdGbsK
3C5cnuhR9f/YKiPZOZGL9ss=
=fvzQ
-----END PGP SIGNATURE-----