[development] $node namespace woes -- can we fix this in D6?

[Sean Robertson]

I like that idea a lot.  I'd think that a lot of changes needing to be 
done in other modules related to this could be done with search and 
replaces couldn't they?  Doesn't seem like it should be too hard.


adrian rossouw wrote:
> 
> On 31 May 2007, at 10:42 PM, Derek Wright wrote:
> 
>>
>> right, i saw that and appreciate it.  however, i'm talking about a 
>> more drastic, core-wide purge of directly touching $node, not just 
>> fixing up the collision with book and path.  perhaps that's too 
>> ambitious for D6...
>>
> 
> Doesn't nodeapi still use the $additions array ?
> 
> couldn't we get away with changing how it merges the data?
> 
> function node_invoke_nodeapi(&$node, $op, $a3 = NULL, $a4 = NULL) {
>   $return = array();
>   foreach (module_implements('nodeapi') as $name) {
>     $function = $name .'_nodeapi';
>     $result = $function($node, $op, $a3, $a4);
>     if (isset($result) && is_array($result)) {
>  // one line change here. Gets rid of an array_merge too.
>       $return[$name] = $result; 
>     }
>     else if (isset($result)) {
>       $return[] = $result;
>     }
>   }
>   return $return;
> } 
> 
> obviously,the big work is changing everywhere that accesses the node 
> object. And that goes all the way down to the theme layer.
> 

-- 
Sean Robertson
Web Developer
NGP Software, Inc.
seanr at ngpsoftware.com
(202) 686-9330
http://www.ngpsoftware.com