[development] What about reviewing patches?

[Stella Power]

There's a patch against the coder module waiting to be reviewed (I know it's
not core), but this patch will add functionality to coder which will allow
you to run a code review on patches.  You can paste in the patch, or just
provide the URL to it.  It might help speed up the process slightly.

Cheers,
Stella

On Wed, Aug 13, 2008 at 10:55 PM, Yuval Hager <yuval at avramzon.net> wrote:

> On Wednesday 13 August 2008, Nathaniel Catchpole wrote:
> > So if you already have HEAD installed (I pretty much only clean my
> > database before or after reviewing a patch with an upgrade path or
> > schema change), you can do this:
> >
> > // clean your HEAD of old changes.
> > cvs -q diff | patch -p0 -R
> >
> > wget http://drupal.org/files/issues/somepatch.patch
> >
> > patch -p0 < somepatch.patch
> >
> > 1 out of 1 hunks failed etc.
> >
> > Mark to code needs work with 'needs a re-roll'.
>
> Can't this process be automated? I think I remember something about a
> process
> that scans for stale patches - does it still exist?. The
> close-fixed-after-two-weeks bot seems to be doing a very nice work!
>
> --
> Yuval Hager
> [@] yuval at avramzon.net
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.drupal.org/pipermail/development/attachments/20080813/fafd35e8/attachment.htm