[development] What about reviewing patches?

Chris Johnson cxjohnson at gmail.com
Thu Aug 14 13:09:49 UTC 2008

You are doing nothing wrong, Katherine.

Everybody reads their email with an email client that's been optimized
with years and years of experience.  Virtually no one has a Drupal
development environment and tools which have been optimized to that
extent.  As you described, Katherine, it takes real time to install
and test patches.  I took about 2 minutes to write this, far less time
than it would even take to go find a patch I was interested in, read
the issue and download the patch, much less give it a thorough test
and then write a review of that test.

Folks who suggest you can do reviews in the time it takes to review or
write a quick comment in email are wrong, wrong, wrong for 99.9% of
the development community out there.


On Wed, Aug 13, 2008 at 3:08 PM, Katherine Senzee
<katherine at esquaredworkshops.com> wrote:
> On Wed, Aug 13, 2008 at 12:52 PM, Nathaniel Catchpole
> <catch56 at googlemail.com> wrote:
>> Some patch reviews take less than 30 seconds, especially when the
>> issue queue is long and has lots of stale patches in it.
> I'm not sure I follow. I review patches when I get the time, but I
> figure on at least 20 minutes -- read the issue, check out HEAD, apply
> the patch, create a new database, install the test site,
> download/install devel, generate stuff, see if the patch works as
> advertised, post my review. If I have a recent enough HEAD install I
> figure I can skip the database bit and just use my existing database,
> but it's still a decent chunk of time. What am I doing wrong?
> --
> Katherine Senzee (ksenzee)
> esquaredworkshops.com

More information about the development mailing list