[development] sessions problem

Sheryl (Permutations Software) sheryl at permutations.com
Wed Dec 24 14:23:21 UTC 2008


Jamie Holly wrote:

> I took a quick look at the module and found this in phpfreechat_room:

      if (is_numeric($user->uid)) {
        $_SESSION['drupal_user'] = $user;
      }

> This creates a lot of overhead. The user object can become really large 
> depending upon what different modules are doing things with it. I looked 
> through the code and the only part of the user object I see being used 
> is $user->uid in phpfreechat_prepare_params(). I don't even see any real 
> reason to store the uid, since you have the global $user that is going 
> to be available for that session. I would say a good starting point is 
> dumping that all together, since you have a global $user that gets 
> loaded when the session is loaded.

Thanks so much for taking a look. This is part of the legacy code I
inherited and did not touch because it was working. I'll try taking it out
and see what happens.

Many thanks!

	- Sheryl




More information about the development mailing list