[development] the time of $op is over?

David Timothy Strauss david at fourkitchens.com
Fri May 9 15:50:02 UTC 2008

Please get rid of $op at least in the cases where the arguments change. I want to see an end to $arg1, etc.

----- "Gábor Hojtsy" <gabor at hojtsy.hu> wrote:

> Hello,
> Now that the registry patch landed, it looks like the time of $op
> might be over. General hooks implementing different branches with $op
> will always be loaded regardless of the exact need for them. Larry
> already suggests using the more granular *_preprocess_hookname() type
> of callbacks instead of the generic *_preprocess() callbacks for
> theme
> stuff, so that only those needed will be loaded. Take nodeapi for
> example. Code for loading nodes might often be needed, but not code
> for updating or deleting them, right? Those could easily be admin.inc
> stuff.
> So what do you think about $op? Should we evaluate on a case-by-case
> basis to make function level callbacks out of $op's or just do it
> wholesale (no, I am not volunteering for a patch) to get an overall
> consistent API.
> Gabor

More information about the development mailing list