[development] the time of $op is over?

James Walker walkah at walkah.net
Fri May 9 23:08:28 UTC 2008

Having just finished a workshop where we have to explain this to new  
drupal developers, I'd like to echo David's sentiment - having $op -  
specific parameters is *very* confusing.

On 9-May-08, at 10:50 AM, David Timothy Strauss wrote:

> Please get rid of $op at least in the cases where the arguments  
> change. I want to see an end to $arg1, etc.
> ----- "Gábor Hojtsy" <gabor at hojtsy.hu> wrote:
>> Hello,
>> Now that the registry patch landed, it looks like the time of $op
>> might be over. General hooks implementing different branches with $op
>> will always be loaded regardless of the exact need for them. Larry
>> already suggests using the more granular *_preprocess_hookname() type
>> of callbacks instead of the generic *_preprocess() callbacks for
>> theme
>> stuff, so that only those needed will be loaded. Take nodeapi for
>> example. Code for loading nodes might often be needed, but not code
>> for updating or deleting them, right? Those could easily be admin.inc
>> stuff.
>> So what do you think about $op? Should we evaluate on a case-by-case
>> basis to make function level callbacks out of $op's or just do it
>> wholesale (no, I am not volunteering for a patch) to get an overall
>> consistent API.
>> Gabor

More information about the development mailing list