[development] Shortening file names downloaded from webpage

[Frederik Grunta]

Someone correct me if I am wrong, but I doubt it.

I just wrote up a quick script on my PC that MD5's 1000 40 character strings
- it executes in 0.00061 seconds. I need to do about 2 million until the
script hits the one second mark.

Unless you are processing an extremely large amount of images, I would say
the overhead of calling md5() can be ignored.

- Frederik

2009/9/15 nitin gupta <nitingupta.iitg at gmail.com>

> Hi,
>
> Any webpage contains a lot of images, I am not aware of the time complexity
> of the function implementation, but won't it will be an overkill to generate
> so many md5 hashes?
>
> Looking forward.
>
> Message: 1
> Date: Mon, 14 Sep 2009 21:16:12 +0530
> From: nitin gupta <nitingupta.iitg at gmail.com>
> Subject: [development] Shortening file names downloaded from webpage
> To: development at drupal.org
> Message-ID:
>        <4f59ac610909140846x5efff3bai3bc4a5deb5054b37 at mail.gmail.com>
> Content-Type: text/plain; charset="iso-8859-1"
>
> Hello,
> I am maintaining a module FeedAPI ImageGrabber. It downloads a relevant
> image from a webpage of the feed-item and stores it along with the node. I
> found that the module sometimes gave the 'filename too long error' (
> http://drupal.org/node/505964). It happens because I was saving the image
> file with the name as basename($image_url).
>
> But to solve the issue, I am now trying this code to shorten the filename.
>
> $arr = parse_url($image_url);
> $filename = basename($arr['path']);
>
> This code solves the problem by removing the query and fragments of the
> url.
> Does anyone know of any better way to handle this? Can anyone point out any
> issues with this code?
>
> Regards,
> Nitin Kumar Gupta
> http://publicmind.in/blog
> -------------- next part --------------
> An HTML attachment was scrubbed...
> URL: <
> http://lists.drupal.org/pipermail/development/attachments/20090914/1269e63c/attachment-0001.htm
> >
>
> ------------------------------
>
> Message: 2
> Date: Mon, 14 Sep 2009 17:12:40 +0100
> From: Stewart Robinson <stewsnooze at gmail.com>
> Subject: Re: [development] Shortening file names downloaded from
>        webpage
> To: development at drupal.org
> Message-ID:
>        <b84e952a0909140912v339b22e1s395357c6cbad792b at mail.gmail.com>
> Content-Type: text/plain; charset="iso-8859-1"
>
> Why not just md5() the full URL and store that instead.
> i.e.
>
> $filename = md5($arr['path']);
>
> --
> Regards,
> Nitin Kumar Gupta
> http://publicmind.in/blog
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.drupal.org/pipermail/development/attachments/20090915/c240e6b5/attachment.htm>