[drupal-devel] [bug] Missing <div> container on HTML output
Issue status update for http://drupal.org/node/20079 Project: Drupal Version: cvs Component: book.module Category: bug reports Priority: minor Assigned to: Anonymous Reported by: budda Updated by: stefan nagtegaal Status: patch Why don't we remove the menu-<div>?? We can style it using .block-user etc, right? Stefan. stefan nagtegaal Previous comments: ------------------------------------------------------------------------ April 6, 2005 - 19:46 : budda Line 588 should be made to output the tree navigation within a container the same as the core navigation block - to keep consistent. new line 588: return '<div class="menu"><ul>'. $tree .'</ul></div>'; You are still able to format the book tree navigation different to the core navigation block as this tree is a child of css class 'book-block'. ------------------------------------------------------------------------ April 6, 2005 - 19:48 : killes@www.drop.org Attachment: http://drupal.org/files/issues/book_28.patch (558 bytes) Here's the patch. ------------------------------------------------------------------------ April 6, 2005 - 21:34 : Dries Where does Drupal core emit a class="menu" ? ------------------------------------------------------------------------ April 6, 2005 - 21:43 : jhriggs Line 89 of menu.module in menu_block(): $data['content'] = '<div class="menu">'. theme('menu_tree', $delta) .'</div>' ; Should the change maybe be made to theme_menu_tree() instead to take care of all of them at once? And if so, should the class be called "tree" rather than "menu"? ------------------------------------------------------------------------ April 7, 2005 - 11:26 : budda Class "tree" would be good. But would this change break any existing themes? Also - the tree menu is used within the book pages at the footer to show nested pages - so would you want that to be within the same class?
I disagree. The div is useful for getting around IE5 problems with padding. Also, this div shouldn't be nixed unless you're going to be thorough and junk *all* "extraneous" divs in Drupal. Themers rely on such things (SFX would break, for example), so changing standard div usage is a big decision. "menu" also makes more sense for most people -- especially since it could be styled horizontally and completely *unlike* a tree. My two cents. Chris On 4/7/05, Steven Wittens <steven@acko.net> wrote:
The class should be on the <ul> instead.
Steven Wittens
Op 12-apr-05 om 0:31 heeft Chris Messina het volgende geschreven:
I disagree. The div is useful for getting around IE5 problems with padding.
Also, this div shouldn't be nixed unless you're going to be thorough and junk *all* "extraneous" divs in Drupal. Themers rely on such things (SFX would break, for example), so changing standard div usage is a big decision.
"menu" also makes more sense for most people -- especially since it could be styled horizontally and completely *unlike* a tree.
My two cents.
Chris
On 4/7/05, Steven Wittens <steven@acko.net> wrote:
The class should be on the <ul> instead.
Steven Wittens
I would really like to remove all extraneous divs and implement the theme('box')-approach, mentioned on the Drupal Conference by Ber Kessels.. I think that adding classes to elements other than a <div> should is good, because you do not use more markup than absolutely needed. I think it would also be a good idea to completely minimize the drupal.css. We should get rid of all eye-candy things, and only leave in there which is _really_ important, or make it overrideable.. (Steven, I know your answer! ;-) At last, i don't see what the problem is between applied CSS against a <ul>-element or <div>. With both approaches we can do exactly the same things, and can get the same results. I truly think that the less html-markup we have in our code, the better it is.. And, _every_ piece of HTML should be overridable inside the theme. So, imo breaking the themes for the introduction drupal 4.7 shouldn't be a big problem, but I would like to know how you guys think of that.. Kind regards, Stefan
participants (4)
-
Chris Messina -
stefan nagtegaal -
Stefan Nagtegaal -
Steven Wittens