Not nearly as harsh as I was expecting, which is a good thing. :)

Believe me, I tried really hard <g> -- Morbus Iff ( HOW DO I DELIT TEH TREE FILEZ?!@! ) Technical: http://www.oreillynet.com/pub/au/779 Enjoy: http://www.disobey.com/ and http://www.videounderbelly.com/ aim: akaMorbus / skype: morbusiff / icq: 2927491 / jabber.org: morbus

Great. Now setup some sort of queue where I can throw in a couple of my modules for a thrashing ;)

The queue is currently being handled internally - that is, send us an email and we'll slot you in somewhere. Note, though, that we've had pretty good response to this so far, and have a handful of modules already interested. -- Morbus Iff ( i desire penance for your sins ) Technical: http://www.oreillynet.com/pub/au/779 Enjoy: http://www.disobey.com/ and http://www.videounderbelly.com/ aim: akaMorbus / skype: morbusiff / icq: 2927491 / jabber.org: morbus

How will you guys handle it when you get a ton of module creators start banging down your door to get a review? Will you consider bringing on others who might give reviews of the inevitably huge amount of requests you're going to get? Do you think this could potentially lead to important patch reviews as well?

Well, we're pretty much there already. At an innocent estimate, there are 12 modules now in the queue, and chx and I, both busy off our rockers, had planned to only do one a week. Oh, and I have a baby coming any day now ;) As for bringing on others, I'm ... cautious about it. On one hand, yes, the entire point of this exercise is to bring up the level of quality in contrib, and the best way to do that is to encourage more eyeballs and an attention to detail. On the other hand, I've yet to see anyone as anal as me when it comes to a code review, and I'd be ... ... cautious about posting code reviews that didn't have my level of anality on a site that largely exists because of a post I wrote complaining about code quality ;) (If I'm anal about code quality, I'm also anal about content quality). But, really, this site just started. We don't have the details worked out and, certainly, the community has some sort of say in its direction because the community is who we're writing this for. So, if anyone did want to get involved per se, definitely speak up. Note, though, that there are 2000+ modules in contrib. Even with a dozen more people reviewing at the level of anality I'd like, we're not going to change the world, or contrib, in a month. As for module creators banging down the doors, ideally, the intention of these reviews are to point out obvious, fatal, and learned, flaws, design, style, and otherwise, that every Drupal developer could benefit from. A module who is #13 in the queue is at a distinct advantage over the module at #2 in the queue, because they can address our discovered gripes in modules #1 to #12, before we get to them. That's a powerful motivator. -- Morbus Iff ( all of the above - the only checkbox worth checking ) Technical: http://www.oreillynet.com/pub/au/779 Enjoy: http://www.disobey.com/ and http://www.videounderbelly.com/ aim: akaMorbus / skype: morbusiff / icq: 2927491 / jabber.org: morbus

On Thu Apr 10 2008 10:45:03 am Jerad Bitner wrote:

On Thu, Apr 10, 2008 at 1:38 PM, Morbus Iff <morbus@disobey.com> wrote:

...

The queue is currently being handled internally - that is, send us an email and we'll slot you in somewhere. Note, though, that we've had pretty good response to this so far, and have a handful of modules already interested.

How will you guys handle it when you get a ton of module creators start banging down your door to get a review? Will you consider bringing on others who might give reviews of the inevitably huge amount of requests you're going to get? Do you think this could potentially lead to important patch reviews as well?

After several reviews have been published, I think if people just read them and apply the suggestions to their own code, 90% of the review will be done already, saving chx and Morbus from a queue of hundreds. -- Jason Flatt http://www.oadaeh.net/ Father of Six: http://www.flattfamily.com/ (Joseph, 15; Cramer, 13; Travis, 11; Angela; Harry, 7; and William, 2) Linux User: http://www.kubuntu.org/ Drupal Fanatic: http://drupal.org/

Are you going to handle it in a manner similar to a security release and give the maintainer a few days to commit a patch before the post goes live?

No, I don't personally intend that, quite simply because they're not security reviews and there is nothing to be lost by having the post appear before things are "fixed". Save for this very first review, for Printer-Friendly Pages, our queue is filled with people who /want/ these reviews, and have knowingly agreed to have the results made /public/. There's no clock to beat, nor embarrassment you didn't bring upon yourself ;) The intent of the reviews is to increase code /quality/, which /only occasionally directly/ equates to an end-user benefit. Sure, you can fix bugs and speed up a function, and perhaps make this work a little more closely to core but, to the end-user, it's not going to make a huge amount of difference - they may notice some of the more UI-related things, or that something is a little faster, but they're not going to know if you committed faster good code or faster crappy code. -- Morbus Iff ( they should rename controlled chaos to morbus droppings ) Technical: http://www.oreillynet.com/pub/au/779 Enjoy: http://www.disobey.com/ and http://www.videounderbelly.com/ aim: akaMorbus / skype: morbusiff / icq: 2927491 / jabber.org: morbus