On Thu, 10 Nov 2005 22:18:44 -0500 James Walker <walkah@walkah.net> wrote:

I won't go so far as to say maybe upload.module should do something similar... ;)

I like this. It sounds like a much better solution then what upload has now. Now, in my world, I dont have that much trouble with dangling images due to peoples ugly operating systems crashing (or ppl closing the browsers). I /do/ have a lot of trouble with GD and or imagemagic crashing (mostly because morons cannot understand the difference between a 20Meg image and a 500k one!). One of my reasons for starting this general upload stuff, is to be able to handle these kind of problems in a central place. My plan in my new system is to uplaod the image, and even insert it in the table. if its there, if it has a uid/nid/wid (whateverid) it is finished, finito. even if a browser crashes: its there. files without an id are indeed orphans (like walkahs images in /tmp) as are files that were processed, but not yet inserted in that table. A cron can then delete all non-wid files from the table AND the FS. And a cron can delete all files from the FS that are not in the databasetable. Ber

Hmm,

Create a proper 'file' form element that handles all the background stuff for you.

And then a 'files' element for multiple files (ala upload)

You could add an extra couple of variable to their defaults .. ie :

function system_elements() { $info['file'] = array('#domain' => 'node', '#dest' => variable_get ('files_dir', ''), '#key' => $node->nid) return $info; }

This would make it absolutely braindead easy to upload a file.

you just add a file element in it, and you'd use either one of the common domains, or create your own. (ie: image, user, node)

I absolutely do not understand what you are talking about. It probably is because i don't understand the formAPI completely. Yet. But I think you misunderstood my code/plans for the file system :) Till now, I did not use the form api niftyness in my file system, so I am very happy if someone could give a hand there, and reduce some of my code/hooks by using that niftyness! Ber

On Sat, 12 Nov 2005 14:36:58 -0800 andrew morton <drewish@katherinehouse.com> wrote:

I'm not any kind of Forms ninja, but I think I've got a reasonable understanding of it. Please let me know what I can do to help you with it.

In a nutshell: I introduced a fileapi system, nearly a 1-to-1 clone of nodapi, only then for any file object. It reacts on "save", "validate", etc. And it also reacts on "form". That hook_fileapi($file, 'form', $form) should return a form array, as well as that it passes along the existing form array. In that way modules can alter the form for a file. Anywhere. For example to turn a certain file form into a list of file forms (to allow uploading more then one file at once). Or to change a title or description. Or to remove something from the form. I am confident that all this no longer needs a hook, since the formapi has its own "override" system. I think that one form of type "upload", will suffice. That type should: * have automatically the javascript/ajax stuff with it. * be called anywhere a module wants to call it. * invoke the correct fileapi actions. Regards, Bèr -- Bèr Kessels Drupal services bler.webschuur.com www.webschuur.com ber@jabber.webschuur.com