[drupal-devel] [bug] Throttle doesn't need hook_perm anymore
Issue status update for http://drupal.org/node/18491 Project: Drupal Version: cvs.tar Component: throttle.module Category: bug reports Priority: minor Assigned to: Anonymous Reported by: Anonymous Updated by: Anonymous Status: patch Attachment: http://drupal.org/files/issues/throttle_perm.patch (579 bytes) Since the throttle block has been removed from the throttle module, there is no longer a need for the "access throttle block" permission. Attached patch removes the throttle_perm function. Anonymous
Since the throttle block has been removed from the throttle module, there is no longer a need for the "access throttle block" permission. Attached patch removes the throttle_perm function.
Is there now no longer any quick way to see how many pages the Drupal engine has served in the past 60 seconds? :-( -Jeremy
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Jeremy Andrews wrote: |>Since the throttle block has been removed from the throttle module, |>there is no longer a need for the "access throttle block" permission. |>Attached patch removes the throttle_perm function. | | | Is there now no longer any quick way to see how many pages the Drupal | engine has served in the past 60 seconds? :-( | | -Jeremy I agree with Jeremy, the throttle block is very useful. What is the justification for its removal? - -Brady -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.0 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org iD8DBQFCLF4wO+lwfsap+f0RAulKAJ9hx0z9HO2eVtd2OCrHvn8q2V2lVQCaAjxY uziBkYe+6QZchfWw3GqI8KE= =P409 -----END PGP SIGNATURE-----
Jeremy Andrews wrote:
Since the throttle block has been removed from the throttle module, there is no longer a need for the "access throttle block" permission. Attached patch removes the throttle_perm function.
Is there now no longer any quick way to see how many pages the Drupal engine has served in the past 60 seconds? :-(
It got removed because the throttle module no longer relies on the number of pages served. Instead, it looks at the number of concurrent anonymous users and/or the number of concurrent authenticated users. This simplified both the code and the configuration a great deal. If you still want such block, create a PHP block that queries the 'sessions' table. It is easy enough. -- Dries Buytaert :: http://www.buytaert.net/
On Mon, 07 Mar 2005 21:58:18 +0100 Dries Buytaert <dries@buytaert.net> wrote: [...]
If you still want such block, create a PHP block that queries the 'sessions' table. It is easy enough.
Fair enough. That'll work. Though I'm surprised so few people find such a block useful -- I find it essential to administering my website. Cheers, -Jeremy
On Mon, 07 Mar 2005 22:39:57 +0100 Steven Wittens <steven@acko.net> wrote: [...]
The throttle functionality is only useful for large drupal sites, which are not the majority of sites out there ;).
Actually, I don't use it for the throttle anymore. It is how I can tell what's going on with the page in general. If things are sluggish, for example, I check how many pages have been served in the last 60 seconds. If it's an abnormally high value, I know to look for a spider or a link from a busy website, etc. (It is possible for the "guests online" value to be low if all the hits are coming from the same IP) If instead it's an average or low number, then I look elsewhere, ie making sure that some other process isn't running on the webserver hogging CPU. In the end I suppose it really doesn't matter. I'll use Dries' suggestion and create a simple PHP block. -Jeremy
participants (5)
-
Anonymous -
Brady Jarvis -
Dries Buytaert -
Jeremy Andrews -
Steven Wittens