[drupal-devel] [feature] 2 additional hooks to form_textarea to support module writers who are extending it.

gordon drupal-devel at drupal.org
Sun Mar 6 09:17:36 UTC 2005

Issue status update for http://drupal.org/node/18417

 Project:      Drupal
 Version:      4.5.2
 Component:    base system
 Category:     feature requests
 Priority:     normal
 Assigned to:  Anonymous
 Reported by:  jbond
 Updated by:   gordon
 Status:       patch

I do not think that these 2 additional hooks are needed. This will
really add alot of additional overhead as it is going to call every
textarea hook 4 times for every textarea on a page. Besides these
modifiaction can be handled better and cleaner in the javascript. If
you take a look at Xinha/HTMLArea or FckEditor they both manipulate the
dom once the page has loaded, and not during. This is a much better and
cleaner method as it means that you can attach to any textarea with
only a few commands.
This is what javascript excels at. So I don't think this is needed.


Previous comments:

March 5, 2005 - 19:54 : jbond

Attachment: http://drupal.org/files/issues/common.inc_8.patch (1.83 KB)

This patch is for common.inc function form_textarea(). It adds two
additional hooks for module writers.
1) A new hook "post-title" which works the same as "pre" and "post" but
allows html to be inserted between the title of the element and the
textarea. This makes it easier to insert a row of buttons (say) that
sit just on top of the textarea.
2) A new hook "attributes" which takes an array() from modules that
provide it and merges it into the $attributes array for the textarea.
Wysywig editors typically need to add javascript handlers for things
like onClick and this provides a simple way for the module to add them.


March 5, 2005 - 20:00 : jbond

Attachment: http://drupal.org/files/issues/common.inc_9.patch (1.83 KB)

Apologies. the first patch had ms win line endings. This one should be
unix line endings.

More information about the drupal-devel mailing list