[development] Strip out theme functions into a .theme file

Larry Garfield larry at garfieldtech.com
Thu Aug 3 18:42:45 UTC 2006


On Thu, August 3, 2006 1:11 pm, Khalid B said:
> On 8/3/06, Morbus Iff <morbus at disobey.com> wrote:
>> > So, I'd propose replacing theme_foo() with foo.theme.  Such files
>> would
>>
>> For what it's worth, I'm against file-per-function, but don't
>> have time to get into it further right now.
>
> I am concerned about a file per function too, from the sheer number of
> .theme files that we will have (clutter) and their possible impact on
> performance.
>
> Adrian seems to think it is not a performance issue though.

As I said, I'm not sure what the performance trade-off would be without
actually benchmarking it.  I'm just remembering chx's split mode patch,
which seemed a net win (trading parsing time for disk IO).  Think of this
as "pre-done split mode" for themes. :-)

--Larry Garfield



More information about the development mailing list