[development] developing book review -- two blocks or two modules?

[Larry Garfield]

Hm, I remember fixing that before.  Please file a bug report in the issue 
queue and I'll look into it ASAP.  (I've got a similar setup that I'm 
upgrading from 4.7.0 to 4.7.2 later today, so I hope I don't run into the 
same issue. <g>)  Thanks.

On Saturday 03 June 2006 10:25, Srimal Jayawardena wrote:
> hey
>
> tnx for the ideas .. really appreciate the active list.
>
> but i get the following error when i try to add a review using nodereview:
>
> * warning : Invalid argument supplied for foreach()in
> /var/www/drupal-4.7.2/modules/nodereview/noderiview_node_nodereview.inc on
> line 134
>
>
> * warning : Invalid argument supplied for foreach()in
> /var/www/drupal-4.7.2/modules/nodereview/noderiview_node_nodereview.inc on
> line 214
>
> But it says your review was created
>
> However it says 'Page not found' when i click  to display reviews.
>
> I have the following versions :
>
> drupal - 4.7.2
> nodereview = 4.7.0 (cvs)
> views module = cvs
> votingapi = cvs
>
> cvs - as of 3/6/2006 today
>
> am i missing something?
>
> tnx
>
> srimal.
>
> On 6/3/06, Larry Garfield <larry at garfieldtech.com> wrote:
> > userreview.module and nodereview.module were developed at the same time.
> > I don't think either of us knew about the other when we were writing
> > them. I'm of course partial to the one I wrote, but I've not tried the
> > other.
> >
> > I also didn't mean to use book.module.  nodereview.module lets you review
> > any node type.  So create a "book" node type (or "product" or "thing" or
> > "whatever" node), and then review that.
> >
> > --
> > Larry Garfield
> >
> > On Fri, June 2, 2006 2:56 pm, Laura Scott said:
> > > Please allow me to correct myself. What I meant to refer to is
> > > "userreview" by dado -- http://drupal.org/node/53611
> > >
> > > Laura
> > >
> > > On Jun 2, 2006, at 10:21 AM, Laura Scott wrote:
> > >> Wouldn't the node review module be a place to start? http://
> > >> drupal.org/node/59051 I'm only just now trying it on a new site,
> > >> but it seems to do much of what you ask.
> > >>
> > >>> On Friday 02 June 2006 06:07, Srimal Jayawardena wrote:
> > >>>> hi
> > >>>>
> > >>>> im working on a book review module to allow multiple reviews (the
> > >>>> existing
> > >>>> one only supports a single review per module)
> > >>>>
> > >>>> I plan to so there will be two objects
> > >>>>   - a book
> > >>>>   - and a review
> > >>>>
> > >>>> Is it better to have both as two blocks in the same module ? or
> > >>>> have two
> > >>>> separate modules?
> > >>>>
> > >>>> Any good places to check on this ?
> > >>>>
> > >>>> tnx in advance.
> > >>>>
> > >>>> srimal.

-- 
Larry Garfield			AIM: LOLG42
larry at garfieldtech.com		ICQ: 6817012

"If nature has made any one thing less susceptible than all others of 
exclusive property, it is the action of the thinking power called an idea, 
which an individual may exclusively possess as long as he keeps it to 
himself; but the moment it is divulged, it forces itself into the possession 
of every one, and the receiver cannot dispossess himself of it."  -- Thomas 
Jefferson