January 2005 - Development - lists.drupal.org

[drupal-devel] Revised proposal for improving Drupal structure
by Nedjo Rogers 23 Jan '05

23 Jan '05

Dear fellow Drupal community members, Building on the extensive comments received on my first draft, I've prepared a revised proposal for updating the Drupal decision-making structure, moving from what commenters called the current "dictatorship" model to one that recognizes Drupal's characteristic as a community project. See the revisions here: http://drupal.org/node/15916#comment-26370 My aim is to protect and maintain the current strengths of our project--while making some fairly small but important changes to help ensure its long term health and sustainability. I'm confident that those who were concerned with my initial proposal will find that this revised one directly addresses their concerns. As suggested, I've made the changes even more gradual--just enough to accomplish the aims of moving past a strict "dictatorship" model and to continue putting in place the building blocks of project sustainability. I've provided strong protections and vetos to keep the existing leadership control and avoid tying down the the leadership or sacrificing the positive lead roles. Finally, I've kept the CVS access (which, as Steven correctly says, is a technicality) with the Project Management Committee. Please read and comment on the revised proposal! I'd greatly appreciate comments on this revised proposal--particularly ones that actually reference what I'm proposing! I appreciate the time that Drupal members have given to this important matter. Other open source software projects have benefited from focused work on structure and organizational development. The Plone CMS, for example, last year created the Plone Foundation to support its development, investing the foundation with ownership of Plone while keeping development in the control of project teams, each with a leader. While it may strike some as bothersome or even lacking in due respect, attention to and discussion of structure and decision-making is an essential part of making a strong, successful project. Thanks, Nedjo Rogers

1 0

[drupal-devel] New sitemap module
by K B 23 Jan '05

23 Jan '05

I have checked into the repository a new simple sitemap module. This module allows a taxonomy based overview of the site, in a hierarchy view. Can someone please create a project page for it, and give me access to that node so I can update it. Here is the README.txt for it: Description: ------------ This is a simple site map module, providing a hierarchy overview of the site's taxonomy. Features: --------- This module provides several options that customize its look and feel: * An overview section on the top of the page can contain any text you want * Can exclude certain taxonomies from the site map page. * Can show the number of nodes under each taxonomy term. * Can list the nodes under each taxonomy term, with hyperlinks for each * If taxonomies have descriptions, then a mouseover description is shown * Can list the author and number of comments for each node, also by a mouseover Database: --------- This module does not require any new database tables to be installed. Installation: ------------- Please see the INSTALL document for details.

2 4

[drupal-devel] cvs log messages
by no-reply＠zind.net 23 Jan '05

23 Jan '05

File: /modules/translation/translation.module 1.3.2.2 DRUPAL-4-5 Date: January 23, 2005 - 19:05 User: axel Minor improvement with link to original node. ---------------------------------------------------------------------- File: /sandbox/scouten/postcard/CHANGELOG.txt 1.1 /sandbox/scouten/postcard/INSTALL.ru.txt 1.1 /sandbox/scouten/postcard/INSTALL.txt 1.1 /sandbox/scouten/postcard/po/postcard-module.pot 1.1 /sandbox/scouten/postcard/postcard.module 1.1 /sandbox/scouten/postcard/postcard.mysql 1.1 /sandbox/scouten/postcard/README.ru.txt 1.1 /sandbox/scouten/postcard/README.txt 1.1 /sandbox/scouten/postcard/TODO.txt 1.1 Date: January 23, 2005 - 18:56 User: scouten Alternative version of postcard.module. (Only minimally tested at this point. Use at own risk.) - Removed "POSTCARD" variable for module renaming. - Postcard module no longer gropes the internal variables & data structures of image.module. - Compatible with the James Walker (sandbox) version of image.module. - Remove dependency on taxonomy module. - Removed separate navigation to postcard gallery. - Add "send a postcard" link to each image. - Always show e-mail field, even if user is logged in. (Prefill with known e-mail address if so.) ---------------------------------------------------------------------- File: /modules/node.module 1.449 Date: January 23, 2005 - 16:20 User: dries - I had to modify chx's patch/change because it did not work with PHP5. Please double-check. ---------------------------------------------------------------------- File: /modules/sitemap/INSTALL 1.6 /modules/sitemap/README.txt 1.2 /modules/sitemap/sitemap.module 1.7 Date: January 23, 2005 - 16:00 User: kbahey Added the capability to be configured as a block, thus providing a side bar navigation menu based on the taxonomy of your site. ---------------------------------------------------------------------- File: /modules/node.module 1.448 Date: January 23, 2005 - 15:45 User: dries - Patch #16026 by chx: fixed node-level permissions. ---------------------------------------------------------------------- File: /modules/user.module 1.432 Date: January 23, 2005 - 15:39 User: dries - Patch #16028 by Goba: added class="form-password" to the password form. ---------------------------------------------------------------------- File: /modules/upload.module 1.19 Date: January 23, 2005 - 15:37 User: dries - Patch #16023 by chx: the upload.module still used the old node_access_*_sql calls. ---------------------------------------------------------------------- File: /misc/drupal.css 1.92 /modules/archive.module 1.76 Date: January 23, 2005 - 15:36 User: dries - Patch #15655 by Goba: allow blank days in the calendar to be styled using CSS, and tidied up the calendar's CSS. ---------------------------------------------------------------------- File: /database/updates.inc 1.83 /modules/statistics.module 1.183 Date: January 23, 2005 - 15:32 User: dries - Patch #15962 by Goba: fixed the association between the accesslog data and the nodes. ---------------------------------------------------------------------- File: /modules/cvslog/cvs.css NONE /modules/cvslog/cvs.module 1.37 Date: January 23, 2005 - 15:07 User: dries - Further integrated CVS accounts and user accounts. - Refactored the search page. - Temporary removed the mail functionality. - Changed HTML output (and removed stylesheet). - Reorganized permissions. - Rewrote some SQL queries. ---------------------------------------------------------------------- File: /modules/copyright/INSTALL.txt 1.3 Date: January 23, 2005 - 15:05 User: veridicus Adjusted links and elaborated on some details ---------------------------------------------------------------------- File: /modules/copyright/INSTALL.txt 1.2.2.1 DRUPAL-4-5 Date: January 23, 2005 - 15:04 User: veridicus Adjusted links and elaborated on some details ---------------------------------------------------------------------- File: /modules/livediscussions/live_discussions.module 1.4 Date: January 23, 2005 - 14:52 User: prometheus6 Block output uses theme_item_list() to make it themeable ---------------------------------------------------------------------- File: /modules/translation/translation.module 1.3.2.1 DRUPAL-4-5 Date: January 23, 2005 - 13:16 User: axel Fix bug #15891 (clean urls), partly released feature request #15892 (languages list). Some code cleanup, minor improvements. ---------------------------------------------------------------------- File: /modules/translation/CHANGELOG.txt 1.2 /modules/translation/po/ru.po 1.2 /modules/translation/po/translation-module.pot 1.2 /modules/translation/translation.module 1.3 Date: January 23, 2005 - 13:10 User: axel Fix bug #15891 (clean urls), partly released feature request #15892 (languages list). Some code cleanup, minor improvements. ---------------------------------------------------------------------- File: /modules/mail_archive/CHANGELOG.txt 1.10 /modules/mail_archive/mail_archive.module 1.11 Date: January 23, 2005 - 13:06 User: jeremy o fix raw message view (added hidden menu item) o fix from/subject search (added hidden menu item) ---------------------------------------------------------------------- File: /modules/filestore2/filestore2.module 1.27 Date: January 23, 2005 - 01:35 User: gordon - add node_access compatibility ---------------------------------------------------------------------- File: /translations/it/statistics-module.po 1.4 Date: January 23, 2005 - 00:37 User: matteo Matteo - terminata traduzione ---------------------------------------------------------------------- File: /modules/mail_archive/CHANGELOG.txt 1.9 /modules/mail_archive/mail_archive.module 1.10 /modules/mail_archive/README.txt 1.8 Date: January 22, 2005 - 22:56 User: jeremy - mail_archive_module: o use pager when displaying expanded thread, only showing n messages per page o display categorized mail archives page modeled after forum module ---------------------------------------------------------------------- File: /modules/node.module 1.447 Date: January 22, 2005 - 22:33 User: unconed Documenting a tricky regexp. ---------------------------------------------------------------------- File: /modules/bbcode/bbcode-help.inc 1.4 Date: January 22, 2005 - 20:28 User: goba preserve linkability and push headers down one (due to the page having a h1 title already) ----------------------------------------------------------------------

1 0

[drupal-devel] [task] Better default workflow
by jvandyk 23 Jan '05

23 Jan '05

Project: Drupal Version: cvs Component: node system Category: tasks Priority: normal Assigned to: drumm Reported by: drumm Updated by: jvandyk Status: patch While I think this patch is a good step forward over what currently exists, the name 'default workflow' is misleading. Really what these settings do is to set initial preferences for built-in Drupal node states, called 'options'. So +1 for this patch. In the future we should look towards the integration of content settings with flexible content types and real workflow [1]. [1] http://drupal.org/project/workflow jvandyk Previous comments: ------------------------------------------------------------------------ December 10, 2004 - 02:27 : drumm Attachment: http://drupal.org/files/issues/types1.png (8.05 KB) This is a screenshot of the page replacing the 'default workflow.' ------------------------------------------------------------------------ December 10, 2004 - 02:29 : drumm Attachment: http://drupal.org/files/issues/types2.png (18.41 KB) This is what you get by clicking 'configure.' ------------------------------------------------------------------------ December 10, 2004 - 03:01 : drumm Attachment: http://drupal.org/files/issues/default_workflow.diff (10.79 KB) The default workflow page quickly becomes usuable as modules are added. I think it works much better broken up into one page per content type. This is a very basic patch which simply moves around the UI and does not change any functionality. I see lots of potential in following this path: * The submission guidelines would make sense on this page. Have the node module put those in, no need to have it duplicated in all the modues. * This page could be moved around to be a top level admin menu with local tasks 'list' and 'add new type' for making lightweight types on the fly instead of the very lightweight modules we have now. * Permissions for who can create nodes or edit their own might make sense on or next to these pages. * The various elements of the create content form, or even the node view, could be reordered with weights. This requires modules implementing hook_nodeapi('settings') to return strings containing the form elements instead of associative arrays. ------------------------------------------------------------------------ December 10, 2004 - 03:09 : moshe weitzman Perhaps we could preserve the overview of all node types and settings in read only table view. then an edit click would lead to the form you show. i think the overview of all settings at once is useful sometimes. ------------------------------------------------------------------------ December 10, 2004 - 08:35 : Dries This is a step in the right direction but the patch needs to evolve a bit before it is commit-worthy. For one, I would use form_group() rather than a form_item-hack. For consistency, table headers should start with a capital letter. Furthermore, I support the idea of creating a more prominent workflow-menu. Moving the story and forum settings to this page, might make sense, although I'm not sure people expect to find the 'submission guidelines' or 'forum structure settings' under 'workflow'. I guess it would work. Either way, this patch has potential so keep working on it. ------------------------------------------------------------------------ December 10, 2004 - 15:57 : tostinni Is this : Configure Workflow by roles [2] could be a way of improvement to ? Good ideas for the patch, thanks. [2] http://drupal.org/node/13129 ------------------------------------------------------------------------ December 16, 2004 - 22:22 : Dries The statistics module's "Display node counter" setting could be part of the workflow system (that or it should be added to the theme's "Toggle display" settings). Similarly, the "Display post information on" setting on the global theme configuration page might be better of being part of the workflow system. ------------------------------------------------------------------------ December 17, 2004 - 09:55 : Bèr Kessels Display and rendering setings should always be part of the theme settings, and preferably only the global settings. they have nothing to do with workflow, and will confuse people if they are "hidden"there. Similar to the "permissions" for upload, that are (were?) hidden there, since uploading has little to do with "allowing uploads". ------------------------------------------------------------------------ January 21, 2005 - 00:26 : drumm Attachment: http://drupal.org/files/issues/default_workflow_0.diff (16.22 KB) Here is a cleaned up patch which: - Capitalizes the column headers - Uses form_checkboxes() instead of the form_item() hack Because I wanted to use form_checkboxes() rather than a form_group() I had to make those 5 variables into one array. There is an update to set the one variable per node type to the values of the five old ones, and delete the five. I have not benchmarked the difference of one array per node type in the variables table vs. five booleans (ints) per node type, but I expect it might be faster. I do have more ideas for what should be done once this first step is finished. - I think 'content types' should be a menu item in the navigation menu, not a local task. This will let us put a 'add content type' tab in the logical place when/if it is time to do that. Also this page is buried now. - I think that the submission guidelines and minimum words should go on these pages. - I think form_group() should be used once the form grows. We could stick what we have now in a 'Workflow' fieldset. - I think that the 'settings' $op of hook_nodeapi() should be rethought and maybe put in another hook. - I think that node create/edit permissions could go on these pages. - I think that this form should have a 'save' $op and use system_settings_save() because that limits what modules can do to using variables. - I think that there should be a 'validate' $op so modules can do validation. - I think that the five options should be rethought. However, these are all separate issues which should have their own patches and debate and many will have to wait until 4.7. But this gets the door open for modules and ideas in 4.6. I'm willing to put more in the overview table, but I would like input on what it should look like to avoid width problems and be as usable as possible moving forward. Perhaps that should wait for another patch? ------------------------------------------------------------------------ January 21, 2005 - 00:32 : drumm BTW, I consider the added 'else' in system.module to be a bugfix. I'm not exactly sure why system_settings_save() does a drupal_goto(), but it helps make the form act a lot more predictably if it does the same type of returning or goto for whichever button is pressed. ------------------------------------------------------------------------ January 22, 2005 - 09:28 : stefan nagtegaal Wow, i really like this patch! This implementation is very clean and looks consistant with the way the input format's are configured. (Which is imo one of the best UI we have.) +1 for this.. ------------------------------------------------------------------------ January 23, 2005 - 17:33 : stefan nagtegaal Dries, what does this patch need more before you commit this? This is an improvement qua consistency, it gives us more space to use the nodeapi, AND it is very, very clean.. A big +1 again for this patch... -- View: http://drupal.org/node/14170 Edit: http://drupal.org/project/comments/add/14170

1 0

[drupal-devel] [task] Better default workflow
by stefan nagtegaal 23 Jan '05

23 Jan '05

Project: Drupal Version: cvs Component: node system Category: tasks Priority: normal Assigned to: drumm Reported by: drumm Updated by: stefan nagtegaal Status: patch Dries, what does this patch need more before you commit this? This is an improvement qua consistency, it gives us more space to use the nodeapi, AND it is very, very clean.. A big +1 again for this patch... stefan nagtegaal Previous comments: ------------------------------------------------------------------------ December 10, 2004 - 03:27 : drumm Attachment: http://drupal.org/files/issues/types1.png (8.05 KB) This is a screenshot of the page replacing the 'default workflow.' ------------------------------------------------------------------------ December 10, 2004 - 03:29 : drumm Attachment: http://drupal.org/files/issues/types2.png (18.41 KB) This is what you get by clicking 'configure.' ------------------------------------------------------------------------ December 10, 2004 - 04:01 : drumm Attachment: http://drupal.org/files/issues/default_workflow.diff (10.79 KB) The default workflow page quickly becomes usuable as modules are added. I think it works much better broken up into one page per content type. This is a very basic patch which simply moves around the UI and does not change any functionality. I see lots of potential in following this path: * The submission guidelines would make sense on this page. Have the node module put those in, no need to have it duplicated in all the modues. * This page could be moved around to be a top level admin menu with local tasks 'list' and 'add new type' for making lightweight types on the fly instead of the very lightweight modules we have now. * Permissions for who can create nodes or edit their own might make sense on or next to these pages. * The various elements of the create content form, or even the node view, could be reordered with weights. This requires modules implementing hook_nodeapi('settings') to return strings containing the form elements instead of associative arrays. ------------------------------------------------------------------------ December 10, 2004 - 04:09 : moshe weitzman Perhaps we could preserve the overview of all node types and settings in read only table view. then an edit click would lead to the form you show. i think the overview of all settings at once is useful sometimes. ------------------------------------------------------------------------ December 10, 2004 - 09:35 : Dries This is a step in the right direction but the patch needs to evolve a bit before it is commit-worthy. For one, I would use form_group() rather than a form_item-hack. For consistency, table headers should start with a capital letter. Furthermore, I support the idea of creating a more prominent workflow-menu. Moving the story and forum settings to this page, might make sense, although I'm not sure people expect to find the 'submission guidelines' or 'forum structure settings' under 'workflow'. I guess it would work. Either way, this patch has potential so keep working on it. ------------------------------------------------------------------------ December 10, 2004 - 16:57 : tostinni Is this : Configure Workflow by roles [1] could be a way of improvement to ? Good ideas for the patch, thanks. [1] http://drupal.org/node/13129 ------------------------------------------------------------------------ December 16, 2004 - 23:22 : Dries The statistics module's "Display node counter" setting could be part of the workflow system (that or it should be added to the theme's "Toggle display" settings). Similarly, the "Display post information on" setting on the global theme configuration page might be better of being part of the workflow system. ------------------------------------------------------------------------ December 17, 2004 - 10:55 : Bèr Kessels Display and rendering setings should always be part of the theme settings, and preferably only the global settings. they have nothing to do with workflow, and will confuse people if they are "hidden"there. Similar to the "permissions" for upload, that are (were?) hidden there, since uploading has little to do with "allowing uploads". ------------------------------------------------------------------------ January 21, 2005 - 01:26 : drumm Attachment: http://drupal.org/files/issues/default_workflow_0.diff (16.22 KB) Here is a cleaned up patch which: - Capitalizes the column headers - Uses form_checkboxes() instead of the form_item() hack Because I wanted to use form_checkboxes() rather than a form_group() I had to make those 5 variables into one array. There is an update to set the one variable per node type to the values of the five old ones, and delete the five. I have not benchmarked the difference of one array per node type in the variables table vs. five booleans (ints) per node type, but I expect it might be faster. I do have more ideas for what should be done once this first step is finished. - I think 'content types' should be a menu item in the navigation menu, not a local task. This will let us put a 'add content type' tab in the logical place when/if it is time to do that. Also this page is buried now. - I think that the submission guidelines and minimum words should go on these pages. - I think form_group() should be used once the form grows. We could stick what we have now in a 'Workflow' fieldset. - I think that the 'settings' $op of hook_nodeapi() should be rethought and maybe put in another hook. - I think that node create/edit permissions could go on these pages. - I think that this form should have a 'save' $op and use system_settings_save() because that limits what modules can do to using variables. - I think that there should be a 'validate' $op so modules can do validation. - I think that the five options should be rethought. However, these are all separate issues which should have their own patches and debate and many will have to wait until 4.7. But this gets the door open for modules and ideas in 4.6. I'm willing to put more in the overview table, but I would like input on what it should look like to avoid width problems and be as usable as possible moving forward. Perhaps that should wait for another patch? ------------------------------------------------------------------------ January 21, 2005 - 01:32 : drumm BTW, I consider the added 'else' in system.module to be a bugfix. I'm not exactly sure why system_settings_save() does a drupal_goto(), but it helps make the form act a lot more predictably if it does the same type of returning or goto for whichever button is pressed. ------------------------------------------------------------------------ January 22, 2005 - 10:28 : stefan nagtegaal Wow, i really like this patch! This implementation is very clean and looks consistant with the way the input format's are configured. (Which is imo one of the best UI we have.) +1 for this.. -- View: http://drupal.org/node/14170 Edit: http://drupal.org/project/comments/add/14170

1 0

[drupal-devel] [task] Forum menu item should be suggested
by drumm 23 Jan '05

23 Jan '05

Project: Drupal Version: cvs Component: forum.module Category: tasks Priority: normal Assigned to: drumm Reported by: drumm Updated by: drumm Status: patch Attachment: http://drupal.org/files/issues/forum.module.patch (619 bytes) I would think that the forums menu item would be an ideal thing for admins to be able to enable if they want. This patch exposes the bug at http://drupal.org/node/15976. drumm -- View: http://drupal.org/node/15977 Edit: http://drupal.org/project/comments/add/15977

2 1

[drupal-devel] [bug] node access not working.
by gordon 23 Jan '05

23 Jan '05

Project: Drupal Version: cvs Component: node.module Category: bug reports Priority: critical Assigned to: Anonymous Reported by: gordon Updated by: gordon Status: patch Ah, I actually thought that I saw the function node_node_grants(). I think we need to get this in asap, esp if people are using the node_priv_byrole module. gordon Previous comments: ------------------------------------------------------------------------ January 23, 2005 - 09:38 : gordon Attachment: http://drupal.org/files/issues/node_22.patch (1.24 KB) I have found that since the node_rewrite_sql() patch has been applied the node_access doesn't seem to be working. I have tracked it down to the node_access_join_sql() and node_access_where_sql in which it checks for the existance of the access_grants hook. This hook access_grants doesn't actually exist, and should really be the node_grants() hook. This is actually stopping the node_rewrite_sql() from working. Attached is a patch to correct this. ------------------------------------------------------------------------ January 23, 2005 - 11:13 : gordon Looking at this more, I beleive that this is critical because of the incorrect checking of the node_grants hook every user is able to see all nodes, but I have a feeling that they maybe able to see the teaser. ------------------------------------------------------------------------ January 23, 2005 - 20:22 : chx Attachment: http://drupal.org/files/issues/node_23.patch (1.22 KB) While you are right about the fact that I have made a bug here, the fix is also wrong. node_access_grants calls module_invoke_all('node_grants') so indeed module_implements('node_grants') is needed. module_implements('node_grants') will an array with the names of the modules which implement hook_node_grants. If there are none, it will return an empty array. The array('node') thing was required for access_grants, 'cos node_access_grants always exists. Not so with node_node_grants -- this never exists. Enough chit-chat, let's see the patch. -- View: http://drupal.org/node/16026 Edit: http://drupal.org/project/comments/add/16026

1 0

[drupal-devel] [bug] node access not working.
by chx 23 Jan '05

23 Jan '05

Project: Drupal Version: cvs Component: node.module Category: bug reports Priority: critical Assigned to: Anonymous Reported by: gordon Updated by: chx Status: patch Attachment: http://drupal.org/files/issues/node_23.patch (1.22 KB) While you are right about the fact that I have made a bug here, the fix is also wrong. node_access_grants calls module_invoke_all('node_grants') so indeed module_implements('node_grants') is needed. module_implements('node_grants') will an array with the names of the modules which implement hook_node_grants. If there are none, it will return an empty array. The array('node') thing was required for access_grants, 'cos node_access_grants always exists. Not so with node_node_grants -- this never exists. Enough chit-chat, let's see the patch. chx Previous comments: ------------------------------------------------------------------------ January 23, 2005 - 00:38 : gordon Attachment: http://drupal.org/files/issues/node_22.patch (1.24 KB) I have found that since the node_rewrite_sql() patch has been applied the node_access doesn't seem to be working. I have tracked it down to the node_access_join_sql() and node_access_where_sql in which it checks for the existance of the access_grants hook. This hook access_grants doesn't actually exist, and should really be the node_grants() hook. This is actually stopping the node_rewrite_sql() from working. Attached is a patch to correct this. ------------------------------------------------------------------------ January 23, 2005 - 02:13 : gordon Looking at this more, I beleive that this is critical because of the incorrect checking of the node_grants hook every user is able to see all nodes, but I have a feeling that they maybe able to see the teaser. -- View: http://drupal.org/node/16026 Edit: http://drupal.org/project/comments/add/16026

1 0

[drupal-devel] [bug] upload.module node rewrite sql
by chx 23 Jan '05

23 Jan '05

Project: Drupal Version: cvs Component: upload.module Category: bug reports Priority: normal Assigned to: chx Reported by: chx Updated by: chx Status: patch Attachment: http://drupal.org/files/issues/upload_rewrite.patch.txt (710 bytes) upload module is using the old node_access_*_sql calls. Sorry, forgot to include with big node rewrite patch. chx -- View: http://drupal.org/node/16023 Edit: http://drupal.org/project/comments/add/16023

1 2

[drupal-devel] Sexy Drupal sites
by Steven Wittens 23 Jan '05

23 Jan '05

Check out the links recently posted to this thread: http://drupal.org/node/7443#comment-25130 These are some seriously sexy Drupal sites... :D Steven

1 0