August 2009 - Development - lists.drupal.org

Why I don't Upload a Module to Drupal
by Sam Polenta 14 Sep '09

14 Sep '09

I have made a few custom modules for clients. Some of them maybe other people would want. I would be happy to give them to whoever wants them, BUT it's not necessarily so simple as that. Mostly they have some customization for the particular site so I would have to generalize them like with a settings page etc. Then I would have to clean up the code a bit. Some would need an install and uninstall routine which I didn't do because it's only for one site anyway. I would be happy even, in theory, to release them on drupal.org but aside from the time to prepare them, which I don't really have, I also don't have time to support them. So I figure even if I did fix it up a bit and put it online, I am then expected to support it. I am not a lazy person nor do I just suck the blood of everyone else who contributes to Drupal without giving back. I do try to help people on the forums a bit and the truth is that I help to "make the world a better place" in other ways. I volunteer at a local NPO to help people--when I sit down at the computer, it's mostly to work. I need to make a living and this is how I do it. So I don't think I'm a total pig--not at all really because I do volunteer my time, but just for other causes aside from Drupal. Do people think my reasons are wrong for not releasing my code? I guess the main thing is that I'm not prepared to support any issues or requests etc. that may come up. Thanks.

14 16

Request to review Guidelines for writing MySQL and PostgreSQL compliant SQL
by Jean-Michel Pouré 29 Aug '09

29 Aug '09

Dear friends, Just a quick note that I added some information in the manual: Developing Drupal using PostgreSQL: http://drupal.org/node/338676 Especially, "Guidelines for writing MySQL and PostgreSQL compliant SQL": http://drupal.org/node/555514 This page lists major differences between MySQL and PostgreSQL syntax. Some issues can be fixed in D7 (some may already as I did not follow development). I saw compatibility functions around. Some automatic casts may be added also in D7 PostgreSQL schema. If this was done, please inform me and I will update the pages or update them yourself. Some need fixing in PostgreSQL. All issues require attention from developers. Would it be possible to review http://drupal.org/node/555514 to make sure anyone agrees on the standard SQL to use for both MySQL and PostgreSQL. When it is done, I will contact PostgreSQL hackers to ask for modifications in PostgreSQL core. Some modifications seem to be in the scope of possibility. Besides, as stated before, I think we would gain to flag minimal PostgreSQL version to 8.4 to benefit from PostgreSQL 8.4 new versions and from a better compatibility with Drupal. PostgreSQL new stable release is PostgreSQL 8.4, even if Debian flags it as unstable. I could upgrade some 500.000 pages sites to PostgreSQL 8.4 without running into a single problem. SO IMHO let us not stick to an old PG version. This is a minor issue, please focus on http://drupal.org/node/555514 Kind regards, Jean-Michel

7 9

Request to remove some of my pages + ask confirmation for guidelines
by Jean-Michel Pouré 28 Aug '09

28 Aug '09

Dear friends, First I would like to apologize for the flame-war about Drupal sending a query returning 21.000 rows and computing it in PHP and then escalating to Dries. I hope that my account will not be blocked and at the same time I admit it was an error to escalate. But understand that I had no other choice because my issue were being closed and my Drupal site was going to explode under load and I did not know how to override this function. IMHO several Drupal users may have experienced several slowdows due to this SQL query. So let's end it with my apologies. On another front, I would like you to delete some of my pages, which are crap and do not meet Drupal quality level: http://drupal.org/node/559986 Was: PostgreSQL cast. Proved to be wrong. ::int was a no-op. http://drupal.org/node/559474 Was: Replace whenever possible LEFT JOINs with INNER JOINs The reason is that I found 1 query in my database which executes faster as an INNER JOIN. So you were right to point out there is no clear rule. This assumption was made when discussed several years ago with a PostgreSQL core developer in an SQL submit. This is not the case in 100%, so let us the SQL planner decide. I will continue my work writing; http://drupal.org/node/555514 I notice that sometimes the server is getting slow. I hope that this will not make my life miserable. I would like to use the name "MySQLism" to name some SQL extensions used by MySQL. This is not a criticism. I treat both databases on the same level and will call PostgreSQLism such things in PostgreSQL. If you don't like, please tell me and I will not use such vocabulary. Kind regards, Jean-Michel

4 5

adding a filter to views
by Lluís 27 Aug '09

27 Aug '09

I have just created a module to allow user to insert a field in a view which is the add of two other numeric fields in the view; so the resulting SQL is like: SELECT a,b, (a+b) c FROM table My approach is different from views_calc because it should work on grouped fields so: SELECT d, sum(a), sum(b), (sum(a)+sum(b)) FROM table GROUP BY d Now I need to add a filter and I don't know really where to start; I suppose I should start from views_handler_filter_numeric but I don't know anything else. Any hint is welcome; and if anybody is interested in this module I can send it. Thanks -- *La vida és com una taronja, què esperes a exprimir-la? *Si creus que l'educació és cara, prova la ignorància. *La vida és com una moneda, la pots gastar en el que vulguis però només una vegada. *Abans d'imprimir aquest missatge, pensa en el medi ambient.

1 0

Creating theme configuration options
by rajasekharan 27 Aug '09

27 Aug '09

Hi, I would like to add a few options in my Drupal theme that can be configured by the administraor such as twitter username, rss feed url and email subscripotion form code and so on. I understand configuraiton of a theme is done under Themes > Configure [next to the theme]. How do I add my own fields to that page for configuring the theme? Thanks in advance, Raj Sekharan

6 6

D7 Query placeholders and values
by Nancy Wichmann 27 Aug '09

27 Aug '09

Since I see Larry Garfield has looked at this list today, I thought I would ask this now since I just had this come up. I know about the new ":label" for substitution in D7 and have no problem with that. But what do I do with an array of values, as in: $types = variable_get('my_types_list', array()); $args += $types; $result = db_query(..., $args); Yes, I properly used db_placeholders to set the "%s" values in place. The query works fine in D6, it's just that I am already looking at teh upgrade and wondered about how to do arrays of values like this, when I can't go in and add a label to them. Nancy E. Wichmann, PMP Injustice anywhere is a threat to justice everywhere. -- Dr. Martin L. King, Jr.

5 7

Strange D6 form issue
by Nancy Wichmann 27 Aug '09

27 Aug '09

Here's a strange new issue. This code is identical between D5 and D6, but in D6 it acts weird. function revision_deletion_list_form($form_state, $node) { ... $form['select'][$vid] = array( '#type' => 'checkbox', '#disabled' => ($vid == $rev->current), '#default_value' => $rev->select, '#return_value' => array( 'action' => 'delete', 'vid' => $vid, 'nid' => $rev->nid, 'title' => $rev->title, 'type' => $rev->type, ), ); $form['class'][$vid] = array('#type' => 'value', '#value' => $rev->class); $form['vid'][$vid] = array('#value' => l($vid, 'node/'. $nid .'/revisions/'. $vid .'/view')); $form['user'][$vid] = array('#value' => $accounts[$rev->uid]); ... } function theme_revision_deletion_list_form($form) { $eo = array('odd' => 'even', 'even' => 'odd'); ... foreach (element_children($form['vid']) as $key) { $class = $eo[$class]; $row_class = $class; if (isset($form['class'][$key])) { $row_class .= ' '. $form['class'][$key]['#value']; unset($form['class'][$key]); } $log_present = !empty($form['log'][$key]['#value']); $output .= '<tr class="'. $row_class . ($log_present ? ' merge-down' : NULL) .'">'; $output .= '<td align="center"'. ($form['select'][$key]['#default_value'] ? ' class="selected"' : '') .'">'. drupal_render($form['select'][$key]) .'</td>'; $output .= '<td>'. drupal_render($form['vid'][$key]) .'</td>'; $output .= '<td>'. drupal_render($form['user'][$key]) .'</td>'; ... } In D5, the array comes back just fine. In D6, the $row_class becomes the returned value, unless I comment that line out, in which case, the correct array is returned. Nancy E. Wichmann, PMP Injustice anywhere is a threat to justice everywhere. -- Dr. Martin L. King, Jr.

2 2

Call for the Drupal community to fix prev/next in forum and in Drupal
by Jean-Michel Pouré 27 Aug '09

27 Aug '09

Dear friends, I call for the Drupal community to fix prev/next scalability in Drupal forum. An open letter is available for Dries BuyTaert. Issue: http://drupal.org/node/559424 Thank you for your attention, Jean-Michel Pouré

5 6

Guidelines for writing efficient SQL code
by Jean-Michel Pouré 27 Aug '09

27 Aug '09

Dear Friends, I welcome your comments on this short guide for writing efficient SQL code in Drupal: http://drupal.org/node/559302 Feel free to start hunting for speed on the two issues mentioned (logging and LEFT JOINs). I will add several tips in the next days. The forum code proved to be heavily broken and I could debug it in 4 hours. So it is very likely that the entire Drupal 6.dev is at stake. Probably Drupal 7 alpha too. Because Drupal makes little use of LEFT JOINs in the code, it is likely that it cannot scale well. Hence a reputation to be slow. But it can change rapidly if you fix the code and apply the tips. I will be back tomorrow with more tips. Hunt for speed now! Kind regards, Jean-Michel

11 20

Re: [development] development Digest, Vol 80, Issue 49 (Action Required)
by no-reply＠boxbe.com 26 Aug '09

26 Aug '09

Dear sender, This message serves as notification that you will not receive any more courtesy notices from our members for two days. Messages you have sent will remain in a lower priority queue for our member to review at their leisure. Future messages will be more likely to be viewed if you are on our member's priority Guest List. Thank you, panneerselvamit34(a)gmail.com About Boxbe This courtesy notice is part of a free service to make email more reliable and useful. Boxbe (http://www.boxbe.com) uses your existing social network and that of your friends to keep your inbox clean and make sure you receive email from people who matter to you. Boxbe: Say Goodbye to Email Overload Visit http://www.boxbe.com/how-it-works?tc=364135679_1938750612

1 0