July 2008 - Development - lists.drupal.org

Can I Indicate failure from hook_user?
by Pushyamitra Navare 03 Sep '08

03 Sep '08

Hello there, I'm new to Drupal, just started a couple of weeks ago. I had following queries regarding hooks. It would be great if someone could provide feedback/suggestions on this. 1. I have written a module which implements "hook_user" and handles "update" and "insert" operations. I want to be able to signal failure/ success from this function. For e.g. if I return failure (boolean FALSE) from "hook_user" for "update" operation, then user update should not happen. I want to do this for "insert", "update" and "delete" operations. * Is it possible to indicate failure in this way so that update/ insert/ delete will not take place? * If yes, how can I accomplish this? 2. Also, I quickly glanced through the user.module. At the top there is a function called "user_module_invoke" which takes care of invoking "hook_user" in various modules. But it does not check for return value, nor does it return anything. So probably result of invoking a hook_user is never checked. If Drupal hooks currently don't check for return value, would it be good idea to add such a functionality? A "pre-operation" hook, which will indicate (boolean TRUE/ FALSE) if the operation should continue or not. Such a hook could be used for various validations when Drupal is integrated with some third-party applications. Any takers for this? Do reply. Thanks in anticipation, Pushyamitra

8 17

FAQ: Why is Drupal still using CVS when X is a much better choice?
by Angela Byron 07 Aug '08

07 Aug '08

Since we're all sick of answering this question every week, I've made an attempt at documenting this here: http://drupal.org/node/289117 If someone has some of the old threads laying around and could help flesh that page out (esp. with "here's where you jump in if you want to change this" stuff), that'd be lovely. -Angie

28 80

howto about git and drupal modules maintain
by Marco Antonio Villegas Vega 31 Jul '08

31 Jul '08

Hello all, I posted a little how to about maintaining drupal modules using git: http://drupal.org/node/288873 I'm sending this email because I see high activity on git related mails. Hope this helps, ________________________________ Marco Antonio Villegas Vega ( __ - __ ) Ing. Informatica http://blog.pucp.edu.pe/marvil07

15 18

sanaaris has invited you to join SlideShare
by sanaaris 30 Jul '08

30 Jul '08

1 0

sanaaris has invited you to join SlideShare
by sanaaris 30 Jul '08

30 Jul '08

1 0

module_preprocess_hook not always called
by Matt Connolly 29 Jul '08

29 Jul '08

Is there a reason why a module's preprocess function is not always called? I have several preprocess functions in a module, and I'd like to preprocess certain pieces of themed content based on content types specific to this module - so, it makes sense to me that the preprocess code should be in the module file. I've traced through the theme() call, and my module's preprocess function name appears in the $hooks array. For example, i'd like to hilight a menu, so I'm trying to preprocess theme(links). My theme has a theme_links function which generates the html output, but in this case the preprocess function is NOT called. For other pieces of themed output, using hook.tpl.php files, the preprocess functions ARE called. Is there a reason why? -Matt

4 5

Re: [development] transferring session info across login event
by Alan Dixon 26 Jul '08

26 Jul '08

i'm wondering if your statement: "the login event regenerates the session" is completely true. I don't believe that the php session cookie changes, and I don't see anywhere (or why) drupal would completely remove all $_SESSION info on login. I think what does happen is that Drupal's private session stuff as stored in the session table gets cleared out (primarily the user object that gets cached, i'm not sure what else), but you don't need to worry about that do you? Put all your pre-login stuff into $_SESSION and then it should still be there after login, I think. - Alan On Mon, Jul 14, 2008 at 1:37 PM, Joe Murray <joe.murray(a)jmaconsulting.biz> wrote: > I have a use case where anonymous users can do a bunch of work, and then at > the end request to save it, which requires logging in (and possibly also > creating an account). The login event regenerates the session, and so far as > I know 5.x does not provide a hook that can be used to copy info from the > old session into the new so that it can be saved in a way that is associated > with the correct uid. I suppose such a hook so would open up lots of > security issues. Still, this is the second time I've confronted this sort of > an issue, and I don't know the correct design pattern to handle it in > Drupal. Comments and suggestions welcome. > > > > Cheers, > > > > Joe Murray, PhD > > President, JMA Consulting > > @ The Centre for Social Innovation > > 215 Spadina Ave, Suite 400, Toronto, Ontario, Canada M5T 2C7 > > 416.466.1281, (416) 644-0116 (f) > > joe.murray(a)jmaconsulting.biz > > Skype: josephpmurray > > -- Alan Dixon, Web Developer http://alan.g.dixon.googlepages.com/

5 7

Proposal: A new Handbook page outlining Best Practices
by Senpai 26 Jul '08

26 Jul '08

Well, we've gone and done it. Several of us got to talking in IRC today and realized that there wasn't a readily available set of Best Practice guidelines for programming within the Drupal framework. This page is a beginning towards a fix for that. Best Practices is now at http://drupal.org/node/287350 We're hoping that everyone on this list who cares enough to send the very best will place a comment on this page with something that they do as a matter of course, and wish everyone else did too. Once the docs team gets enough of these, we'll begin rolling them into a cohesive set of guidelines for Coding within Drupal as it pertains to PHP, MySQL, and the like. High level stuff. Let the fallout commence! -- Joel 'Senpai' Farris "Protection and captivity so often look the same." ** Robert Ludlum

1 0

Left menu missing
by Joel Penner (Volt) 25 Jul '08

25 Jul '08

Hey all, I'm writing an abstraction layer for mssql and got the system up and working minus the left hand menu, it shows only 2 items if i clear the cache table but then after reloading it goes away again. Can someone point me in the right direction in the code? Joel Penner Volt Microsoft Open Source Software Lab

2 6

HTML emails
by Matt Connolly 25 Jul '08

25 Jul '08

I haven't looked at drupal 7 yet, so I'm throwing this out there for discussion. The D6 mail api seems like it's pretty much designed for plain text emails, however, a module's implementation of hook_mail can clearly set the headers of the mail to "Content-Type: text/html; charset=utf-8" and send rich text. For example, I'm looking at using "forward" module for the "email this page" link on a node, and the "simplenews" module, which uses "mimemail" to send rich emails, including attachments. Both "forward" and "mimemail" modules create a html header. The problem occurs when a module implements "drupal_mail_wrapper()" to build a html header when hook_mail has already done that - you can easily end up with bodies like: <!doctype... <-- from drupal_mail_wrapper() <html> <head>...</head> <body><div.... <!doctype. <-- from hook_mail() <html> <head> ... etc. Because there are two opportunities to create the html "head" for the message: in hook_mail and drupal_mail_wrapper. I'm throwing this out there for discussion, I think that the hook_mail should construct the message in a similar fashion to the Form API, specifying a theme for rendering the body part of the message (ie what goes in the <body> tag) and anything special that needs to go in the head as attributes. That way the message can be constructed only once. Besides, email clients have been HTML friendly for a *long* time, so I don't see why Drupal shouldn't have an interface that understands rich email messages. Thoughts? Matt

16 28